Bug 214054 – Heap Snapshot Object Graph view doesn't get populated in some cases when inspecting a JSContext

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Christopher Reid]

When a JSContext is created with a non-null globalObjectClass passed to JSGlobalContextCreateInGroup, that root object is created as an instance of CallbackGlobalObject and not GlobalObject.
The Object graph view only searches for objects that are instances of GlobalObject in the JSContext case so nothing gets populated in this case.

[Christopher Reid]

Created attachment 403723 [details]
patch

[Devin Rousso]

Comment on attachment 403723 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403723&action=review

> Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js:271
> +        this.heapSnapshot.instancesWithClassName("CallbackGlobalObject", (instances) => {

While this is fine, it would be nice to show all roots rather than just a specific few, as these roots may change in the future :)

I believe we could expose a way to iterate `heapSnapshot._nodeOrdinalIsGCRoot`, calling `HeapSnapshot.prototype.serializeNode` on each.

[Devin Rousso]

Comment on attachment 403723 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403723&action=review

>> Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js:271
>> +        this.heapSnapshot.instancesWithClassName("CallbackGlobalObject", (instances) => {
> 
> While this is fine, it would be nice to show all roots rather than just a specific few, as these roots may change in the future :)
> 
> I believe we could expose a way to iterate `heapSnapshot._nodeOrdinalIsGCRoot`, calling `HeapSnapshot.prototype.serializeNode` on each.

this can be done as a FIXME followup bug, or behind a `WI.Setting` btw :)

[Christopher Reid]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 403723 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403723&action=review
> 
> >> Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js:271
> >> +        this.heapSnapshot.instancesWithClassName("CallbackGlobalObject", (instances) => {
> > 
> > While this is fine, it would be nice to show all roots rather than just a specific few, as these roots may change in the future :)
> > 
> > I believe we could expose a way to iterate `heapSnapshot._nodeOrdinalIsGCRoot`, calling `HeapSnapshot.prototype.serializeNode` on each.
> 
> this can be done as a FIXME followup bug, or behind a `WI.Setting` btw :)

Yeah that would be good to have.
I created a followup bug https://webkit.org/b/214092 and will point a FIXME to it when landing.

[Christopher Reid]

Created attachment 403798 [details]
Patch for landing

[EWS]

Committed r264124: <https://trac.webkit.org/changeset/264124>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403798 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65234451>