Bug 214045 – [GTK][WPE] install-dependencies should install the gstreamer plugins

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

When building webkit against system libraries (without flatpak/jhbuild) its needed to have installed the webkit plugins for play media files.
The install-dependencies script should install those.

[Carlos Alberto Lopez Perez]

Created attachment 403691 [details]
Patch

[Xabier Rodríguez Calvar]

I don't know how recommended this is since we have sometimes dependencies on certain patches or certain versions.

[Michael Catanzaro]

Maybe these scripts should be changed to only install whatever dependencies are needed to build the flatpak runtime...?

[Carlos Alberto Lopez Perez]

The idea of the install-dependencies script is to install every package you will need for developing webkit.

The official way of developing developing webkit is with flatpak, but sometimes you might be interested in not using flatpak (I do). So I think its handy that this script makes easier to achieve that.

Currently this scripts install every package you will need for

 - Building webkit with flatpak
 - Building webkit without flatpak (against your system libraries)
 - Running tests (with and without flatpak)


For me that is fine, but if you are concerned with that maybe we can split this scripts?

Perhaps something like this may work:

 - Tools/flatpak/install-dependencies: install dependencies for building/testing with flatpak
 - Tools/gtk/install-dependencies: install dependencies for building/testing without flatpak for gtk
 - Tools/wpe/install-dependencies: install dependencies for building/testing without flatpak for wpe


But this looks it can be more confusing than what we have now. Personally I lean towards keeping this as is. I don't see this extra packages installed by the script as a concern.

[Carlos Alberto Lopez Perez]

BTW, note this scripts are already installing libgstreamer-plugins-bad1.0-dev and  libgstreamer-plugins-base1.0-dev from the system. This patch only changes that the plugins are also installed

[EWS]

Committed r264094: <https://trac.webkit.org/changeset/264094>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403691 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65217902>