Bug 214045 - [GTK][WPE] install-dependencies should install the gstreamer plugins
Summary: [GTK][WPE] install-dependencies should install the gstreamer plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-07 08:25 PDT by Carlos Alberto Lopez Perez
Modified: 2020-07-08 04:03 PDT (History)
10 users (show)

See Also:


Attachments
Patch (4.81 KB, patch)
2020-07-07 08:36 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-07-07 08:25:41 PDT
When building webkit against system libraries (without flatpak/jhbuild) its needed to have installed the webkit plugins for play media files.
The install-dependencies script should install those.
Comment 1 Carlos Alberto Lopez Perez 2020-07-07 08:36:56 PDT
Created attachment 403691 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2020-07-07 09:27:31 PDT
I don't know how recommended this is since we have sometimes dependencies on certain patches or certain versions.
Comment 3 Michael Catanzaro 2020-07-07 09:36:39 PDT
Maybe these scripts should be changed to only install whatever dependencies are needed to build the flatpak runtime...?
Comment 4 Carlos Alberto Lopez Perez 2020-07-07 10:15:26 PDT
The idea of the install-dependencies script is to install every package you will need for developing webkit.

The official way of developing developing webkit is with flatpak, but sometimes you might be interested in not using flatpak (I do). So I think its handy that this script makes easier to achieve that.

Currently this scripts install every package you will need for

 - Building webkit with flatpak
 - Building webkit without flatpak (against your system libraries)
 - Running tests (with and without flatpak)


For me that is fine, but if you are concerned with that maybe we can split this scripts?

Perhaps something like this may work:

 - Tools/flatpak/install-dependencies: install dependencies for building/testing with flatpak
 - Tools/gtk/install-dependencies: install dependencies for building/testing without flatpak for gtk
 - Tools/wpe/install-dependencies: install dependencies for building/testing without flatpak for wpe


But this looks it can be more confusing than what we have now. Personally I lean towards keeping this as is. I don't see this extra packages installed by the script as a concern.
Comment 5 Carlos Alberto Lopez Perez 2020-07-07 10:21:58 PDT
BTW, note this scripts are already installing libgstreamer-plugins-bad1.0-dev and  libgstreamer-plugins-base1.0-dev from the system. This patch only changes that the plugins are also installed
Comment 6 EWS 2020-07-08 04:02:35 PDT
Committed r264094: <https://trac.webkit.org/changeset/264094>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403691 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-08 04:03:17 PDT
<rdar://problem/65217902>