Bug 214036 - [webkitpy] run-minibrowser doesn't handle unicode urls
Summary: [webkitpy] run-minibrowser doesn't handle unicode urls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-07 01:05 PDT by Philippe Normand
Modified: 2020-07-08 03:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2020-07-07 01:08 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2020-07-07 01:21 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.58 KB, patch)
2020-07-07 01:26 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-07-07 01:05:39 PDT 
$ Tools/Scripts/run-minibrowser --wpe "http://alliancefrançaise.nu/"

UnicodeDecodeError raised: 'ascii' codec can't decode byte 0xc3 in position 19: ordinal not in range(128)
Traceback (most recent call last):
  File "/app/webkit/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py", line 59, in main
    return port.run_minibrowser(args)
  File "/app/webkit/Tools/Scripts/webkitpy/port/wpe.py", line 145, in run_minibrowser
    return self._executive.run_command(command + args, cwd=self.webkit_base(), stdout=None, return_stderr=False, decode_output=False)
  File "/app/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 405, in run_command
    close_fds=self._should_close_fds())
  File "/app/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 503, in popen
    string_args = self._stringify_args(args)
  File "/app/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 471, in _stringify_args
    string_args = map(unicode_compatibility.unicode, args)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 19: ordinal not in range(128)
Comment 1 Philippe Normand 2020-07-07 01:08:15 PDT 
Created attachment 403673 [details]
Patch
Comment 2 Philippe Normand 2020-07-07 01:21:05 PDT 
Created attachment 403674 [details]
Patch
Comment 3 Philippe Normand 2020-07-07 01:26:58 PDT 
Created attachment 403676 [details]
Patch
Comment 4 EWS 2020-07-08 03:53:31 PDT 
Committed r264093: <https://trac.webkit.org/changeset/264093>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403676 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-08 03:54:13 PDT 
<rdar://problem/65217669>