Bug 214034 – dyld: Symbol not found: __ZN3WTF19initializeThreadingEv - webkit MacOSX

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joe]

Created attachment 403669 [details]
compilation_log.zip

I'm trying to run safari/webkit from custom build, but at the end I get error like in the topic. From the beginning.

My Os : MacOS Catalina ver 10.15.5

Xcode : 11.5

Webkit source code obtained from git:

git clone git://git.webkit.org/WebKit.git webkit 

next build:

./Tools/Scripts/set-webkit-configuration --asan
./Tools/Scripts/build-webkit
I got info at the end that build succeeded :

** BUILD SUCCEEDED ** [2.393 sec]


====================================================================
 WebKit is now built (1h:03m:30s). 
 To run Safari with this newly-built code, use the
 "Tools/Scripts/run-safari" script.
====================================================================
Trying to run below script I endup with an error:

MagicTerminal:webkit joe$ ./Tools/Scripts/run-safari
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/joe/projects/webkit/WebKitBuild/Release.
dyld: Symbol not found: __ZN3WTF19initializeThreadingEv
  Referenced from: /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
  Expected in: /Users/joe/projects/webkit/WebKitBuild/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore
 in /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari

Any idea how to solve that problem ?
I'm attaching a log from a compilation process.

[Alexey Proskuryakov]

Did this work for you before http://trac.webkit.org/r263635 ? That change had the function renamed, and obviously broke running against shipping Safari, but we weren't sure if it was already broken for other reasons.

[Joe]

Nice! I revert to e1cb69a commit and that solved me problem. So indeed it seems that changes pointed by you are causing mentioned by me issue.
Are you guys planning to solve it somehow ?

Thanks ;)

[Geoffrey Garen]

Yes, we can solve this.

[Geoffrey Garen]

Created attachment 403797 [details]
Patch

[Mark Lam]

Comment on attachment 403797 [details]
Patch

r=me

[EWS]

Committed r264126: <https://trac.webkit.org/changeset/264126>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403797 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65236008>

[Darin Adler]

Comment on attachment 403797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403797&action=review

> Source/WTF/wtf/Threading.cpp:379
> +// This is a compatibility hack to prevent linkage errors when launching older
> +// versions of Safari. initialize() used to be named initializeThreading(), and
> +// Safari.framework used to call it directly from NotificationAgentMain.
> +WTF_EXPORT_PRIVATE void initializeThreading();
> +void initializeThreading()
> +{
> +    initialize();
> +}

Would be nice if we left a slightly more explicit crumb around for *when* we can remove this. I think we used to have a header with these "needed only for old Safari linking" in it, which helped group them for simultaneous removal. Often they were empty functions. Nothing makes me want this function to be in this source file, since the consideration is not about our threading design.