Bug 214032 – Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen()

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen()

[Peng Liu]

<rdar://problem/65041486>

[Peng Liu]

Created attachment 403663 [details]
Patch

[Eric Carlson]

Comment on attachment 403663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987
>      [playerController() setHasEnabledVideo:false];
>      [playerController() setHasVideo:false];

Doesn't seem like we should have to call both of these, shouldn't setting `hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to this patch, but it would be good to change this in a future cleanup.

[Peng Liu]

Comment on attachment 403663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review

>> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987
>>      [playerController() setHasVideo:false];
> 
> Doesn't seem like we should have to call both of these, shouldn't setting `hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to this patch, but it would be good to change this in a future cleanup.

Right! We need to update WebAVPlayerController to do that.

[EWS]

Committed r264030: <https://trac.webkit.org/changeset/264030>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403663 [details].