Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen()
<rdar://problem/65041486>
Created attachment 403663 [details] Patch
Comment on attachment 403663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987 > [playerController() setHasEnabledVideo:false]; > [playerController() setHasVideo:false]; Doesn't seem like we should have to call both of these, shouldn't setting `hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to this patch, but it would be good to change this in a future cleanup.
Comment on attachment 403663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review >> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987 >> [playerController() setHasVideo:false]; > > Doesn't seem like we should have to call both of these, shouldn't setting `hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to this patch, but it would be good to change this in a future cleanup. Right! We need to update WebAVPlayerController to do that.
Committed r264030: <https://trac.webkit.org/changeset/264030> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403663 [details].