Bug 214030 - Add WebCoreNSURLSession SPI to send HTTP/2 ping
Summary: Add WebCoreNSURLSession SPI to send HTTP/2 ping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on: 214747
Blocks:
  Show dependency tree / graph
 
Reported: 2020-07-06 20:56 PDT by Alex Christensen
Modified: 2020-07-24 10:52 PDT (History)
11 users (show)

See Also:

Attachments
Patch (50.94 KB, patch)
2020-07-06 21:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (49.88 KB, patch)
2020-07-06 21:09 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (50.33 KB, patch)
2020-07-06 21:45 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (51.30 KB, patch)
2020-07-07 09:00 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-07-06 20:56:39 PDT 
Add WebCoreNSURLSession SPI to send HTTP/2 ping
Comment 1 Alex Christensen 2020-07-06 21:04:43 PDT 
Created attachment 403661 [details]
Patch
Comment 2 Alex Christensen 2020-07-06 21:04:45 PDT 
<rdar://problem/64495827>
Comment 3 Alex Christensen 2020-07-06 21:09:29 PDT 
Created attachment 403662 [details]
Patch
Comment 4 Alex Christensen 2020-07-06 21:45:18 PDT 
Created attachment 403664 [details]
Patch
Comment 5 Sam Weinig 2020-07-07 07:46:14 PDT 
Comment on attachment 403664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403664&action=review

> Source/WebCore/loader/FrameLoaderClient.h:361
> +    virtual void sendH2Ping(const URL&, CompletionHandler<void(Expected<Seconds, ResourceError>&&)>&&);

This should be pure-virtual. By moving the ASSERT to WebKitLegacy, it will make it clear if it ever gets called that it is WebKitLegacy that has not implemented it.

> Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h:70
> +    virtual void sendH2Ping(const URL&, CompletionHandler<void(Expected<Seconds, ResourceError>&&)>&&);

Same here. This should be pure-virtual.
Comment 6 Alex Christensen 2020-07-07 09:00:19 PDT 
Created attachment 403695 [details]
Patch
Comment 7 EWS 2020-07-07 10:05:03 PDT 
Committed r264021: <https://trac.webkit.org/changeset/264021>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403695 [details].