Bug 214027 - Unable to scroll elcomerico.pe page until the page finishes loading
Summary: Unable to scroll elcomerico.pe page until the page finishes loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-06 20:38 PDT by Simon Fraser (smfr)
Modified: 2020-07-07 11:17 PDT (History)
10 users (show)

See Also:


Attachments
Patch (11.90 KB, patch)
2020-07-06 20:42 PDT, Simon Fraser (smfr)
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-07-06 20:38:07 PDT
Unable to scroll elcomerico.pe page until the page finishes loading
Comment 1 Simon Fraser (smfr) 2020-07-06 20:42:22 PDT
Created attachment 403659 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-07-06 20:42:24 PDT
<rdar://problem/64646259>
Comment 3 Sam Weinig 2020-07-07 08:01:19 PDT
Comment on attachment 403659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403659&action=review

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:282
> -    bool isInvertible() const; // If you call this this, you're probably doing it wrong.
> +    WEBCORE_EXPORT bool isInvertible() const; // If you call this this, you're probably doing it wrong.

Suspicious comment is suspicious. Maybe time to update this comment to be clear about why this might be the case or just remove it?
Comment 4 Simon Fraser (smfr) 2020-07-07 11:17:08 PDT
https://trac.webkit.org/changeset/264031/webkit