Bug 214026 - Fix CrashTracer reported in PDFPlugin::ByteRangeRequest::maybeComplete
Summary: Fix CrashTracer reported in PDFPlugin::ByteRangeRequest::maybeComplete
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-06 20:34 PDT by Brady Eidson
Modified: 2020-07-07 18:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.24 KB, patch)
2020-07-06 20:39 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2020-07-06 20:34:24 PDT 
Fix CrashTracer reported in PDFPlugin::ByteRangeRequest::maybeComplete

<rdar://problem/64884982>
Comment 1 Brady Eidson 2020-07-06 20:39:54 PDT 
Created attachment 403658 [details]
Patch
Comment 2 EWS 2020-07-07 08:20:14 PDT 
Committed r264018: <https://trac.webkit.org/changeset/264018>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403658 [details].
Comment 3 Alexey Proskuryakov 2020-07-07 18:32:09 PDT 
Comment on attachment 403658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403658&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1047
> +    if (!plugin.m_data)
> +        return false;

What makes it OK to access m_data without synchronization? From the ChangeLog, it sounds like it's manipulated from another thread.