Bug 214021 – [macOS] Allow additional IOKit classes for Apple Silicon

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

The WebKit sandbox needs some additional permissions for media playback on Apple Silicon.

[Brent Fulgham]

<rdar://problem/63696732>

[Brent Fulgham]

Created attachment 403642 [details]
Patch

[Brent Fulgham]

Comment on attachment 403642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403642&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:410
> +        (iokit-property "IOSurfaceAcceleratorCapabilitiesDictâ) ;; <rdar://problem/63696732>

Doh! Smart quote!

[Brent Fulgham]

Created attachment 403643 [details]
Patch

[Per Arne Vollan]

Comment on attachment 403643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403643&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:670
> +        (iokit-user-client-class "IOSurfaceRootUserClient") ;; rdar://problem/63696732

I think it would be good to add a CPU check to these two classes.

[Sam Weinig]

Comment on attachment 403643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403643&action=review

> Source/WebKit/ChangeLog:3
> +        [macOS] Allow additional UIKit classes for Apple Silicon

These don't look like UIKit classes. Is this the right change?

[Brent Fulgham]

Comment on attachment 403643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403643&action=review

>> Source/WebKit/ChangeLog:3
>> +        [macOS] Allow additional UIKit classes for Apple Silicon
> 
> These don't look like UIKit classes. Is this the right change?

Yeah, I should have written "IOKit classes"

>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:670
>> +        (iokit-user-client-class "IOSurfaceRootUserClient") ;; rdar://problem/63696732
> 
> I think it would be good to add a CPU check to these two classes.

The diff doesn't show that these are encased in a CPU check for arm64.

[Brent Fulgham]

Created attachment 403698 [details]
Patch

[Sam Weinig]

Comment on attachment 403698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403698&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:670
> +        (iokit-user-client-class "IOSurfaceAcceleratorClient") ;; rdar://problem/63696732
> +        (iokit-user-client-class "IOSurfaceRootUserClient") ;; rdar://problem/63696732

Inconsistent style here. Above you use angle brackets around the radar. Probably want them to be the same.

[Brent Fulgham]

Created attachment 403718 [details]
Patch for landing

[EWS]

Committed r264042: <https://trac.webkit.org/changeset/264042>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403718 [details].