Bug 214011 - [iOS] WAKWindow should override -resignFirstResponder and clear state
Summary: [iOS] WAKWindow should override -resignFirstResponder and clear state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-06 16:02 PDT by Daniel Bates
Modified: 2020-07-06 16:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2020-07-06 16:21 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-07-06 16:02:14 PDT 
WAKWindow maintains state of what the first responder and next responder are. I need way to clear this state when removing a UIWebView from its superview.
Comment 1 Radar WebKit Bug Importer 2020-07-06 16:02:31 PDT 
<rdar://problem/65152410>
Comment 2 Daniel Bates 2020-07-06 16:05:18 PDT 
Note that only -[WAKWindow close] ever nils out this state. -makeFirstResponder early returns if passed nil. In AppKit, -makeFirstResponder:nil would make the window first responder, but -firstResponder is in term of WAKView and there doesn't seem to be an existing concept of a "first responder" window.
Comment 3 Daniel Bates 2020-07-06 16:21:57 PDT 
Created attachment 403631 [details]
Patch
Comment 4 Daniel Bates 2020-07-06 16:27:29 PDT 
Thanks Tim!
Comment 5 Daniel Bates 2020-07-06 16:28:00 PDT 
Comment on attachment 403631 [details]
Patch

Clearing flags on attachment: 403631

Committed r263995: <https://trac.webkit.org/changeset/263995>
Comment 6 Daniel Bates 2020-07-06 16:28:02 PDT 
All reviewed patches have been landed.  Closing bug.