Bug 213991 – Spams system logs with "Current memory footprint: 10 MB"

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

I see new logs in my journal:

Jul 06 09:44:50 chargestone-cave WebKitWebProcess[998142]: Current memory footprint: 25 MB
Jul 06 09:44:52 chargestone-cave WebKitWebProcess[998245]: Current memory footprint: 28 MB
Jul 06 09:44:53 chargestone-cave WebKitWebProcess[998350]: Current memory footprint: 8 MB
Jul 06 09:45:15 chargestone-cave WebKitWebProcess[996536]: Current memory footprint: 52 MB
Jul 06 09:45:15 chargestone-cave WebKitWebProcess[996532]: Current memory footprint: 64 MB
Jul 06 09:45:15 chargestone-cave WebKitWebProcess[996538]: Current memory footprint: 10 MB
Jul 06 09:45:20 chargestone-cave WebKitWebProcess[998142]: Current memory footprint: 25 MB
Jul 06 09:45:22 chargestone-cave WebKitWebProcess[998245]: Current memory footprint: 27 MB
Jul 06 09:45:23 chargestone-cave WebKitWebProcess[998350]: Current memory footprint: 8 MB
Jul 06 09:45:45 chargestone-cave WebKitWebProcess[996536]: Current memory footprint: 52 MB
Jul 06 09:45:45 chargestone-cave WebKitWebProcess[996532]: Current memory footprint: 64 MB
Jul 06 09:45:45 chargestone-cave WebKitWebProcess[996538]: Current memory footprint: 10 MB
Jul 06 09:45:50 chargestone-cave WebKitWebProcess[998142]: Current memory footprint: 13 MB
Jul 06 09:45:52 chargestone-cave WebKitWebProcess[998245]: Current memory footprint: 28 MB
Jul 06 09:45:53 chargestone-cave WebKitWebProcess[998350]: Current memory footprint: 8 MB

It's too much, they are printing every few seconds. This will add up.

[Michael Catanzaro]

Let's do this only on Apple platforms (I understand expectations for log output are different there).

[Michael Catanzaro]

Created attachment 403596 [details]
Patch

[Darin Adler]

Comment on attachment 403596 [details]
Patch

This is OK, but I wonder what the disconnect between macOS logging and other platforms is that makes it good to log on macOS but too noisy elsewhere. That might affect other logging too.

[EWS]

Committed r263978: <https://trac.webkit.org/changeset/263978>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403596 [details].

[Michael Catanzaro]

(In reply to Darin Adler from comment #3) 
> This is OK, but I wonder what the disconnect between macOS logging and other
> platforms is that makes it good to log on macOS but too noisy elsewhere.
> That might affect other logging too.

FWIW, I don't see any other problematic logs in my journal. I think most release logging is not enabled by default. Maybe it's only memory pressure info that's being logged by default? If Apple is OK with getting rid of this particular log entirely, I guess we wouldn't have any disconnect.

[Darin Adler]

Maybe Chris Dumez knows more?