Bug 213985 – [iPadOS] Unable to change focus between Google Docs windows by tapping

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

<rdar://problem/57083267>

[Wenson Hsieh]

Created attachment 403575 [details]
For EWS

[Wenson Hsieh]

Created attachment 403576 [details]
Fix GTK/WPE builds

[Wenson Hsieh]

Created attachment 403598 [details]
Patch

[Darin Adler]

Comment on attachment 403598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403598&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
> +        if (nativeWebTouchEvent.isPotentialTap() && self.hasHiddenContentEditable && self._hasFocusedElement && !self.window.keyWindow)
> +            [self.window makeKeyWindow];

Does the test cover all 4 of these changes?

[Wenson Hsieh]

Comment on attachment 403598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403598&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
>> +            [self.window makeKeyWindow];
> 
> Does the test cover all 4 of these changes?

Unfortunately, the new test doesn’t cover the change in `-mouseGestureRecognizerChanged:` (since there’s currently no way to simulate real trackpad-y mouse events from WebKitTestRunner at the moment).

The three other changes here are covered, however.

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 403598 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403598&action=review
> 
> >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
> >> +            [self.window makeKeyWindow];
> > 
> > Does the test cover all 4 of these changes?
> 
> Unfortunately, the new test doesn’t cover the change in
> `-mouseGestureRecognizerChanged:` (since there’s currently no way to
> simulate real trackpad-y mouse events from WebKitTestRunner at the moment).

I filed <https://bugs.webkit.org/show_bug.cgi?id=213995> to track this.

> 
> The three other changes here are covered, however.

[EWS]

Committed r263979: <https://trac.webkit.org/changeset/263979>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403598 [details].