Bug 213985 - [iPadOS] Unable to change focus between Google Docs windows by tapping
Summary: [iPadOS] Unable to change focus between Google Docs windows by tapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-05 22:16 PDT by Wenson Hsieh
Modified: 2020-07-06 12:46 PDT (History)
11 users (show)

See Also:

Attachments
For EWS (50.52 KB, patch)
2020-07-05 23:31 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix GTK/WPE builds (51.72 KB, patch)
2020-07-05 23:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (51.76 KB, patch)
2020-07-06 09:08 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-07-05 22:16:50 PDT 
<rdar://problem/57083267>
Comment 1 Wenson Hsieh 2020-07-05 23:31:39 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-07-05 23:45:11 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-07-06 09:08:27 PDT 
Created attachment 403598 [details]
Patch
Comment 4 Darin Adler 2020-07-06 11:48:18 PDT 
Comment on attachment 403598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403598&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
> +        if (nativeWebTouchEvent.isPotentialTap() && self.hasHiddenContentEditable && self._hasFocusedElement && !self.window.keyWindow)
> +            [self.window makeKeyWindow];

Does the test cover all 4 of these changes?
Comment 5 Wenson Hsieh 2020-07-06 11:51:00 PDT 
Comment on attachment 403598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403598&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
>> +            [self.window makeKeyWindow];
> 
> Does the test cover all 4 of these changes?

Unfortunately, the new test doesn’t cover the change in `-mouseGestureRecognizerChanged:` (since there’s currently no way to simulate real trackpad-y mouse events from WebKitTestRunner at the moment).

The three other changes here are covered, however.
Comment 6 Wenson Hsieh 2020-07-06 11:57:55 PDT 
(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 403598 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403598&action=review
> 
> >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
> >> +            [self.window makeKeyWindow];
> > 
> > Does the test cover all 4 of these changes?
> 
> Unfortunately, the new test doesn’t cover the change in
> `-mouseGestureRecognizerChanged:` (since there’s currently no way to
> simulate real trackpad-y mouse events from WebKitTestRunner at the moment).

I filed <https://bugs.webkit.org/show_bug.cgi?id=213995> to track this.

> 
> The three other changes here are covered, however.
Comment 7 EWS 2020-07-06 12:45:58 PDT 
Committed r263979: <https://trac.webkit.org/changeset/263979>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403598 [details].