Bug 213968 - [Flatpak SDK] Misc updates
Summary: [Flatpak SDK] Misc updates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-05 02:51 PDT by Philippe Normand
Modified: 2020-07-06 01:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.98 KB, patch)
2020-07-05 02:53 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (5.95 KB, patch)
2020-07-06 01:11 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-07-05 02:51:00 PDT
I have a few changes piling up...
Comment 1 Philippe Normand 2020-07-05 02:53:20 PDT
Created attachment 403550 [details]
Patch
Comment 2 Sergio Villar Senin 2020-07-06 00:53:54 PDT
Comment on attachment 403550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403550&action=review

> Tools/flatpak/flatpakutils.py:1034
> +            runner_args.append("--%s" % arg[10:])

Perhaps we need some clarification about this magic number
Comment 3 Philippe Normand 2020-07-06 01:11:44 PDT
Created attachment 403579 [details]
Patch
Comment 4 Philippe Normand 2020-07-06 01:12:55 PDT
Comment on attachment 403579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403579&action=review

> Tools/flatpak/flatpakutils.py:1035
> +    opt_prefix = "--flatpak-"
> +    for arg in args:
> +        if arg.startswith(opt_prefix):
> +            runner_args.append("--%s" % arg[len(opt_prefix):])

Thanks, I think it looks better now.
Comment 5 EWS 2020-07-06 01:35:36 PDT
Committed r263963: <https://trac.webkit.org/changeset/263963>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403579 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-06 01:36:15 PDT
<rdar://problem/65123062>