Bug 21396 - Remove the OptionalCalleeActivation call frame slot
Summary: Remove the OptionalCalleeActivation call frame slot
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Cameron Zwarich (cpst)
Depends on:
Blocks: 20812
  Show dependency treegraph
Reported: 2008-10-05 22:45 PDT by Cameron Zwarich (cpst)
Modified: 2008-10-06 20:54 PDT (History)
0 users

See Also:

Proposed patch (13.87 KB, patch)
2008-10-06 17:06 PDT, Cameron Zwarich (cpst)
no flags Details | Formatted Diff | Diff
Revised proposed patch (13.86 KB, patch)
2008-10-06 20:15 PDT, Cameron Zwarich (cpst)
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-10-05 22:45:30 PDT
After bug 21364 is resolved, we can do this.
Comment 1 Cameron Zwarich (cpst) 2008-10-06 17:06:14 PDT
Created attachment 24130 [details]
Proposed patch
Comment 2 Cameron Zwarich (cpst) 2008-10-06 20:15:22 PDT
Created attachment 24137 [details]
Revised proposed patch

This fixes the crash. It was a problem with the ScopeChain dereffing in unwindCallFrame().
Comment 3 Oliver Hunt 2008-10-06 20:42:33 PDT
Comment on attachment 24137 [details]
Revised proposed patch

r=me, but i'd like a bug to cover the absence of documentation on op_tear_off_activation and op_enter_with_activation
Comment 4 Cameron Zwarich (cpst) 2008-10-06 20:54:06 PDT
Landed in r37366.