Bug 213954 – [SOUP] Add support for HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

We currently use HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain as SOUP_COOKIE_JAR_ACCEPT_NO_THIRD_PARTY because that's the default, but it's not really supported by libsoup. SOUP_COOKIE_JAR_ACCEPT_NO_THIRD_PARTY is actually HTTPCookieAcceptPolicy::ExclusivelyFromMainDocumentDomain. We need new libsoup API to add the new policy and use the right one. I'm not sure we want to expose the new one in the API though, since it's less restrictive and we now have ITP support.

[Carlos Garcia Campos]

Created attachment 403520 [details]
WIP

This is wip, it requires new libsoup API, and a new release to add version checks to use the new policy. See https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/127

[Carlos Garcia Campos]

After this, I agree we should rename the policies to avoid confusion between "Only" and "Exclusively" as proposed in bug #193458.

[Michael Catanzaro]

Comment on attachment 403520 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=403520&action=review

Looks good.

> Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:294
> -        if (m_thirdPartyCookieBlockingMode == ThirdPartyCookieBlockingMode::All && m_cookieAcceptPolicy == HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain)
> +        if (m_thirdPartyCookieBlockingMode == ThirdPartyCookieBlockingMode::All && m_cookieAcceptPolicy == HTTPCookieAcceptPolicy::ExclusivelyFromMainDocumentDomain)

I think we need a comment to explain why we are rejecting changes to ExclusivelyFromMainDocumentDomain but not to OnlyFromMainDocumentDomain: OnlyFromMainDocumentDomain is the default behavior when running layout tests, we have a couple tests that depend on it, and OnlyFromMainDocumentDomain cannot be set by public API users so they'll never notice.

[Carlos Garcia Campos]

Created attachment 403687 [details]
WIP

Updated and also includes the test expectations.

[Carlos Garcia Campos]

Created attachment 403772 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Philippe Normand]

Comment on attachment 403772 [details]
Patch

I have built this, along with SDK, http tests pass in GTK/Release.

[Carlos Garcia Campos]

(In reply to Philippe Normand from comment #7)
> Comment on attachment 403772 [details]
> Patch
> 
> I have built this, along with SDK, http tests pass in GTK/Release.

Does this mean I can land the patch and the bots will have the new libsoup already?

[Carlos Garcia Campos]

Committed r264156: <https://trac.webkit.org/changeset/264156>

[Philippe Normand]

SDK r264156 is deployed...