Bug 213942 - [WPE] Fix build with clang after r263898
Summary: [WPE] Fix build with clang after r263898
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-03 13:50 PDT by Lauro Moura
Modified: 2020-07-03 14:27 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.23 KB, patch)
2020-07-03 13:54 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2020-07-03 14:01 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2020-07-03 14:02 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-07-03 13:50:57 PDT
The WPE Release Bot is now using clang and caught[1] the following error:

"
DerivedSources/ForwardingHeaders/wtf/HashTable.h:956:17: error: incomplete type 'WTF::StringHash' named in nested name specifier
            if (HashFunctions::safeToCompareToEmptyOrDeleted) {
                ^~~~~~~~~~~~~~~
DerivedSources/ForwardingHeaders/wtf/HashTable.h:466:56: note: in instantiation of function template specialization 'WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::add<WTF::IdentityHashTranslator<WTF::HashTraits<WTF::String>, WTF::StringHash>, const WTF::String &, const WTF::String &>' requested here
        AddResult add(const ValueType& value) { return add<IdentityTranslatorType>(Extractor::extract(value), value); }
                                                       ^
DerivedSources/ForwardingHeaders/wtf/HashSet.h:239:19: note: in instantiation of member function 'WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::add' requested here
    return m_impl.add(value);
                  ^
../../Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:161:39: note: in instantiation of member function 'WTF::HashSet<WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String> >::add' requested here
                manifest.explicitURLs.add(url.string());
                                      ^
DerivedSources/ForwardingHeaders/wtf/text/StringParsingBuffer.h:119:16: note: in instantiation of function template specialization 'WebCore::parseApplicationCacheManifest(const WTF::URL &, const WTF::String &, const char *, int)::(anonymous class)::operator()<WTF::StringParsingBuffer<unsigned char> >' requested here
        return functor(StringParsingBuffer { string.characters8(), string.length() });
               ^
../../Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:82:12: note: in instantiation of function template specialization 'WTF::readCharactersForParsing<WTF::String &, (lambda at ../../Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:82:53)>' requested here
    return readCharactersForParsing(manifestString, [&](auto buffer) -> Optional<ApplicationCacheManifest> {"

[1] https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/34853
Comment 1 Lauro Moura 2020-07-03 13:54:39 PDT
Created attachment 403484 [details]
Patch
Comment 2 Lauro Moura 2020-07-03 14:01:10 PDT
Created attachment 403487 [details]
Patch
Comment 3 Lauro Moura 2020-07-03 14:02:04 PDT
Created attachment 403488 [details]
Patch
Comment 4 EWS 2020-07-03 14:27:30 PDT
Committed r263908: <https://trac.webkit.org/changeset/263908>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403488 [details].