Bug 213936 – WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Darin Adler]

WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD

[Darin Adler]

Created attachment 403475 [details]
Patch

[Darin Adler]

Comment on attachment 403475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403475&action=review

> Source/WebCore/ChangeLog:8
> +        * Sources.txt: Remove #if ENABLE_APPLICATION_MANIFEST and sort files in with the others.

Oops, this should say ENABLE_GAMEPAD.

[Darin Adler]

Looks like I need to modify something so the empty source files get generated, since I am getting this error in the GTK build:

Cannot find source file:
    /app/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp

Maybe the perl scripts need to be changed so they generate an empty file rather than no file at all. Or perhaps a file with a comment "/* This file intentionally left empty. */" in it?

[Darin Adler]

Hmm, no it seems the real problem is that this same error is repeated in the CMake files, where we conditionalize compilation there instead of in the code. I will make the same change to CMake, I guess. That's going to make this more of a pain, but I think it's the right thing to do.

[Darin Adler]

Created attachment 403482 [details]
Patch

[EWS]

Committed r263910: <https://trac.webkit.org/changeset/263910>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403482 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65083720>