Bug 213932 - Remove support for ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE
Summary: Remove support for ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-03 12:28 PDT by Sam Weinig
Modified: 2020-07-03 16:44 PDT (History)
23 users (show)

See Also:


Attachments
Patch (88.81 KB, patch)
2020-07-03 12:39 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (90.33 KB, patch)
2020-07-03 13:48 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (90.32 KB, patch)
2020-07-03 13:53 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-07-03 12:28:49 PDT
Remove support for ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE
Comment 1 Sam Weinig 2020-07-03 12:39:09 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-07-03 12:40:00 PDT
For reference, the macro was renamed from ENABLE_INPUT_TYPE_DATETIME_BROKEN  to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE  https://bugs.webkit.org/show_bug.cgi?id=113254.
Comment 3 Sam Weinig 2020-07-03 13:48:31 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-07-03 13:53:40 PDT
Created attachment 403483 [details]
Patch
Comment 5 Darin Adler 2020-07-03 14:04:35 PDT
Comment on attachment 403483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403483&action=review

> Source/WebCore/html/parser/ParsingUtilities.h:34
> +#include <wtf/Forward.h>
>  #include <wtf/text/StringCommon.h>

A little surprised that StringCommon.h doesn’t include Forward.h.
Comment 6 EWS 2020-07-03 16:43:49 PDT
Committed r263916: <https://trac.webkit.org/changeset/263916>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403483 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-03 16:44:18 PDT
<rdar://problem/65085056>