Bug 213913 - Add testing infrastructure and SPI declaration for HTTP/2 ping
Summary: Add testing infrastructure and SPI declaration for HTTP/2 ping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-02 18:02 PDT by Alex Christensen
Modified: 2020-07-02 19:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (19.81 KB, patch)
2020-07-02 18:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (19.83 KB, patch)
2020-07-02 18:17 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-07-02 18:02:19 PDT 
Add testing infrastructure and SPI declaration for HTTP/2 ping
Comment 1 Alex Christensen 2020-07-02 18:04:37 PDT 
Created attachment 403426 [details]
Patch
Comment 2 Jer Noble 2020-07-02 18:14:22 PDT 
Comment on attachment 403426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403426&action=review

r=me with single nit.

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:77
> +- (void) getUnderlyingHTTPConnectionInfoWithCompletionHandler:(void (^)(_NSHTTPConnectionInfo *connectionInfo))completionHandler;

Nit: Whitespace between ")" and "get..."
Comment 3 Alex Christensen 2020-07-02 18:17:56 PDT 
Created attachment 403429 [details]
Patch
Comment 4 EWS 2020-07-02 19:01:25 PDT 
Committed r263879: <https://trac.webkit.org/changeset/263879>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403429 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-02 19:02:18 PDT 
<rdar://problem/65060003>