Bug 213912 - Change the names of MIMETypeRegistry methods to comply with webkit naming style
Summary: Change the names of MIMETypeRegistry methods to comply with webkit naming style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-02 17:52 PDT by Said Abou-Hallawa
Modified: 2020-07-03 17:42 PDT (History)
26 users (show)

See Also:

Attachments
Patch (29.54 KB, patch)
2020-07-02 18:00 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (33.07 KB, patch)
2020-07-02 18:10 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-07-02 17:52:38 PDT 
Change the name of the following methods:

MIMETypeRegistry::getMIMETypeForExtension
MIMETypeRegistry::getExtensionsForMIMEType
MIMETypeRegistry::getPreferredExtensionForMIMEType
MIMETypeRegistry::getMediaMIMETypeForExtension
MIMETypeRegistry::getMIMETypeForPath
MIMETypeRegistry::getNormalizedMIMEType

To be:

MIMETypeRegistry::mimeTypeForExtension
MIMETypeRegistry::extensionsForMIMEType
MIMETypeRegistry::preferredExtensionForMIMEType
MIMETypeRegistry::mediaMIMETypeForExtension
MIMETypeRegistry::mimeTypeForPath
MIMETypeRegistry::normalizedMIMEType
Comment 1 Said Abou-Hallawa 2020-07-02 18:00:47 PDT 
Created attachment 403424 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-07-02 18:10:39 PDT 
Created attachment 403427 [details]
Patch
Comment 3 EWS Watchlist 2020-07-02 18:11:44 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 EWS 2020-07-03 02:35:52 PDT 
Committed r263890: <https://trac.webkit.org/changeset/263890>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403427 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-03 02:36:19 PDT 
<rdar://problem/65069686>
Comment 6 Fujii Hironori 2020-07-03 17:42:27 PDT 
Committed r263923: <https://trac.webkit.org/changeset/263923>