Bug 213902 – [macOS] Adopt AVPlayer.videoRangeOverride

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[macOS] Adopt AVPlayer.videoRangeOverride

[Jer Noble]

<rdar://problem/63953509>

[Jer Noble]

Created attachment 403407 [details]
Patch

[Jer Noble]

Created attachment 403415 [details]
Patch

[Jer Noble]

Created attachment 403421 [details]
Patch

[Jer Noble]

Created attachment 403423 [details]
Patch

[youenn fablet]

Comment on attachment 403423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403423&action=review

> Source/WebCore/page/Page.cpp:1160
> +    forEachMediaElement([mode] (HTMLMediaElement& element) {

auto&

> Source/WebCore/page/Page.cpp:1183
> +    forEachMediaElement([mode] (HTMLMediaElement& element) {

auto&

> Source/WebCore/platform/ScreenProperties.h:229
> +        WTFMove(*preferredDynamicRangeMode)

WTFMove not needed

> Source/WebCore/platform/mac/PlatformScreenMac.mm:158
> +        screenProperties.screenDataMap.set(displayID, ScreenData { screenAvailableRect, screenRect, colorSpace, screenDepth, screenDepthPerComponent, screenSupportsExtendedColor, screenHasInvertedColors, screenSupportsHighDynamicRange, screenIsMonochrome, displayMask, gpuID, dynamicRangeMode });

add is probably better since displayID should not be already contained here I guess.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:979
> +    // If AVPlayer.videoRangeOverride support is present, there's no need to override HDR moed

s/moed/mode

[Jer Noble]

Created attachment 404874 [details]
Patch for landing

[EWS]

Committed r264710: <https://trac.webkit.org/changeset/264710>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404874 [details].

[Jer Noble]

Landed build fix in r264719: <https://trac.webkit.org/r264719>

[Jer Noble]

Landed another build fix in r264721: <https://trac.webkit.org/r264721>

[David Kilzer (:ddkilzer)]

(In reply to EWS from comment #8)
> Committed r264710: <https://trac.webkit.org/changeset/264710>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 404874 [details].

(In reply to Jer Noble from comment #9)
> Landed build fix in r264719: <https://trac.webkit.org/r264719>

(In reply to Jer Noble from comment #10)
> Landed another build fix in r264721: <https://trac.webkit.org/r264721>

Hopefully last build fix in r264723: <https://trac.webkit.org/r264723>