Bug 213899 – [Flatpak SDK][WPE] Launching the remote inspector kills MB

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sergio Villar Senin]

This is the error I get, seems like the code is trying to access files outside the sandbox:


Error loading libWPEWebInspectorResources.so: /usr/local/lib/wpe-webkit-1.0/libWPEWebInspectorResources.so: cannot open shared object file: No such file or directory

(MiniBrowser:24): GLib-CRITICAL **: 13:04:56.972: g_bytes_get_data: assertion 'bytes != NULL' failed
(MiniBrowser:24): GLib-CRITICAL **: 13:04:56.973: g_bytes_get_data: assertion 'bytes != NULL' failed
(MiniBrowser:24): GLib-CRITICAL **: 13:04:56.973: g_variant_new_bytestring: assertion 'string != NULL' failed
(MiniBrowser:24): GLib-CRITICAL **: 13:04:56.973: g_variant_get_type: assertion 'value != NULL' failed
(MiniBrowser:24): GLib-CRITICAL **: 13:04:56.974: g_variant_type_is_subtype_of: assertion 'g_variant_type_check (type)' failed
(MiniBrowser:24): GLib-CRITICAL **: 13:04:56.974: g_variant_get_type_string: assertion 'value != NULL' failed
(MiniBrowser:24): GLib-ERROR **: 13:04:56.974: g_variant_new: expected GVariant of type 'ay' but received value has type '(null)'

ScriptError raised: Failed to run "[u'/app/webkit/WebKitBuild/Release/bin/MiniBrowser', 'https://immersive-web.github.io/webxr-samples/']" exit_code: -5 cwd: /app/webkit
Traceback (most recent call last):
  File "/app/webkit/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py", line 59, in main
    return port.run_minibrowser(args)
  File "/app/webkit/Tools/Scripts/webkitpy/port/wpe.py", line 146, in run_minibrowser
    return self._executive.run_command(command + args, cwd=self.webkit_base(), stdout=None, return_stderr=False, decode_output=False)
  File "/app/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 435, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/app/webkit/Tools/Scripts/webkitpy/common/system/abstractexecutive.py", line 97, in default_error_handler
    raise error
ScriptError: Failed to run "[u'/app/webkit/WebKitBuild/Release/bin/MiniBrowser', 'https://immersive-web.github.io/webxr-samples/']" exit_code: -5 cwd: /app/webkit

[Philippe Normand]

Oh yeah I saw a similar error today. But I think in GTK it works. Need to debug... :)

[Philippe Normand]

This fails in Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp where I suspect we might need to check an env-var additionally to the build-time hardcoded lib path.

[Philippe Normand]

It works fine in GTK because the inspector commands are loaded from a GResource embedded in the lib.

[Philippe Normand]

Created attachment 403766 [details]
Patch

[Philippe Normand]

Comment on attachment 403766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403766&action=review

> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp:49
> +        const char* path = g_getenv("WEBKIT_INJECTED_BUNDLE_PATH");

I was lazy here. I can a new variable if the reviewer kindly asks :)

[Adrian Perez]

Comment on attachment 403766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403766&action=review

>> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp:49
>> +        const char* path = g_getenv("WEBKIT_INJECTED_BUNDLE_PATH");
> 
> I was lazy here. I can a new variable if the reviewer kindly asks :)

As this is going to be used only for developer builds, I think it is okay
to reuse this variable that is already being set by all our scripts instead
of introducing a new one which would need handling in many places.

[EWS]

Committed r267159: <https://trac.webkit.org/changeset/267159>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403766 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69013637>