Bug 213897 - FloatingPointEnvironment::saveMainThreadEnvironment() is not called for macOS Catalyst apps on Apple Silicon
Summary: FloatingPointEnvironment::saveMainThreadEnvironment() is not called for macOS...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2020-07-02 12:36 PDT by Chris Dumez
Modified: 2020-07-02 13:27 PDT (History)
6 users (show)

See Also:

Patch (5.80 KB, patch)
2020-07-02 12:44 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (6.02 KB, patch)
2020-07-02 12:58 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-07-02 12:36:16 PDT
FloatingPointEnvironment::saveMainThreadEnvironment() is not called on macOS with Apple Silicon. This causes crashes because FloatingPointEnvironment::propagateMainThreadEnvironment() for worker threads on this platform.
Comment 1 Chris Dumez 2020-07-02 12:36:28 PDT
Comment 2 Chris Dumez 2020-07-02 12:44:32 PDT
Created attachment 403388 [details]
Comment 3 Darin Adler 2020-07-02 12:52:14 PDT
Comment on attachment 403388 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=403388&action=review

> Source/WebKit/Shared/ios/AuxiliaryProcessIOS.mm:55
>      UNUSED_PARAM(parameters);
>      UNUSED_PARAM(sandboxParameters);

We could remove the argument names now instead of using UNUSED_PARAM.
Comment 4 Chris Dumez 2020-07-02 12:58:13 PDT
Created attachment 403389 [details]
Comment 5 Mark Lam 2020-07-02 13:05:39 PDT
Comment on attachment 403389 [details]

r=me too.
Comment 6 EWS 2020-07-02 13:27:01 PDT
Committed r263857: <https://trac.webkit.org/changeset/263857>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403389 [details].