Bug 213869 - [JSC] Intl.Collator should set usage:"search" option through ICU locale
Summary: [JSC] Intl.Collator should set usage:"search" option through ICU locale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 213425
  Show dependency tree / graph
 
Reported: 2020-07-01 19:09 PDT by Yusuke Suzuki
Modified: 2020-07-01 23:01 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.66 KB, patch)
2020-07-01 19:11 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (7.70 KB, patch)
2020-07-01 19:53 PDT, Yusuke Suzuki 		ross.kirsling: review+
Details | Formatted Diff | Diff
Patch for landing (7.66 KB, patch)
2020-07-01 20:21 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch for landing (8.13 KB, patch)
2020-07-01 20:49 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-07-01 19:09:03 PDT 
[JSC] Intl.Collator should set usage:"search" option through ICU locale
Comment 1 Yusuke Suzuki 2020-07-01 19:11:32 PDT 
Created attachment 403337 [details]
Patch
Comment 2 Yusuke Suzuki 2020-07-01 19:23:38 PDT 
Comment on attachment 403337 [details]
Patch

I'll add more handling for privateuse.
Comment 3 Yusuke Suzuki 2020-07-01 19:53:26 PDT 
Created attachment 403339 [details]
Patch
Comment 4 Ross Kirsling 2020-07-01 19:55:57 PDT 
Comment on attachment 403339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403339&action=review

LGTM

> JSTests/stress/intl-collator-co-extension.js:6
> +function shouldBeArray(actual, expected) {

I should do this more often...I've used JSON.stringify too much in our Intl tests, haha.
Comment 5 Yusuke Suzuki 2020-07-01 20:18:04 PDT 
Comment on attachment 403339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403339&action=review

> Source/JavaScriptCore/runtime/IntlCollator.cpp:249
> +        dataLocaleWithExtensions = dataLocale.utf8();

I need to make it `m_locale.utf8()` since "co" option in usage:"sort" is effective.
Comment 6 Yusuke Suzuki 2020-07-01 20:21:21 PDT 
Created attachment 403340 [details]
Patch for landing
Comment 7 Yusuke Suzuki 2020-07-01 20:49:01 PDT 
Created attachment 403341 [details]
Patch for landing
Comment 8 Yusuke Suzuki 2020-07-01 22:56:19 PDT 
ios and win failures are unrelated. Win failure is due to bad state of EWS (re-run of EWS is failing). ios thing is failing without this patch.
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fcanvas%2F2d.gradient.radial.cone.bottom.html
Comment 9 Yusuke Suzuki 2020-07-01 23:00:44 PDT 
Committed r263833: <https://trac.webkit.org/changeset/263833>
Comment 10 Radar WebKit Bug Importer 2020-07-01 23:01:23 PDT 
<rdar://problem/65019917>