Bug 213864 - Overlapping content on earny.co
Summary: Overlapping content on earny.co
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-01 15:00 PDT by zalan
Modified: 2020-07-04 06:31 PDT (History)
13 users (show)

See Also:

Attachments
Patch (81.80 KB, patch)
2020-07-01 16:03 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (139.94 KB, patch)
2020-07-02 09:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (142.82 KB, patch)
2020-07-02 11:03 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-07-01 15:00:26 PDT 
<rdar://problem/61011802>
Comment 1 zalan 2020-07-01 16:03:53 PDT 
Created attachment 403327 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-07-01 21:22:43 PDT 
Comment on attachment 403327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403327&action=review

> Source/WebCore/rendering/AutoTableLayout.cpp:75
> +                columnLayout.minLogicalWidth = std::max(columnLayout.minLogicalWidth, 0.f);
> +                columnLayout.maxLogicalWidth = std::max(columnLayout.maxLogicalWidth, 0.f);

I think we prefer std::max<float>()
Comment 3 zalan 2020-07-02 09:19:32 PDT 
Created attachment 403371 [details]
Patch
Comment 4 zalan 2020-07-02 11:03:56 PDT 
Created attachment 403380 [details]
Patch
Comment 5 EWS 2020-07-02 12:45:32 PDT 
Committed r263855: <https://trac.webkit.org/changeset/263855>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403380 [details].