Bug 213816 – WKUserScripts injecting into all frames seem to violate app-bound domains

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

WKUserScripts can inject user script into all frames when the top frame is app-bound, since only the top frame navigation is checked for app-bound status. This seems to violate principles of app-bound domains.

[Kate Cheney]

<rdar://problem/64872296>

[Kate Cheney]

Created attachment 403244 [details]
Patch

[Brady Eidson]

Comment on attachment 403244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403244&action=review

Other than rebasing first and adding a test, looks good.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3461
> -    if (shouldEnableInAppBrowserPrivacyProtections()) {
> +    if (frame->shouldEnableInAppBrowserPrivacyProtections()) {
>          send(Messages::WebPageProxy::ScriptValueCallback({ }, ExceptionDetails { "Unable to execute JavaScript"_s }, callbackID));

You will have to rebase before this lands.

Also, this is an interesting new case that now needs to be tested (as of https://trac.webkit.org/changeset/263727/webkit) - Could you add to the API test an attempt to evaluate javascript to the non app-bound domain should fail?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:113
> +    else if ([task.request.URL.path isEqualToString:@"/should-load-for-main-frame-only"])
> +        countInjectedScriptSource++;

Another way to do this is checking the WKFrameInfo on the WKURLSchemeHandlerTask and see if it's the main frame, and get its URL, etc.

[Kate Cheney]

Created attachment 403250 [details]
Patch

[EWS]

Committed r263806: <https://trac.webkit.org/changeset/263806>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403250 [details].