Bug 213815 – Rename ManifestParser.h/cpp to ApplicationCacheManifestParser.h/cpp to make it clear its not the ApplicationManifestParser (a different thing entirely).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Rename ManifestParser.h/cpp to ApplicationCacheManifestParser.h/cpp to make it clear its not the ApplicationManifestParser (a different thing entirely).

[Sam Weinig]

Created attachment 403238 [details]
Patch

[Darin Adler]

Comment on attachment 403238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403238&action=review

> Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:53
> +template<typename CharacterType> static constexpr bool isManifestNewline(CharacterType character)

This seems like a pretty standard definition of isNewline. Just saying.

> Source/WebCore/loader/appcache/ApplicationCacheManifestParser.h:36
> +    FallbackURLVector fallbackURLs;

Seems a slight shame that we have to include ApplicationCache.h just to get the definition of this vector type.

[Darin Adler]

Comment on attachment 403238 [details]
Patch

Couldn’t set commit-queue+ without seeing more EWS results.

[Sam Weinig]

(In reply to Darin Adler from comment #2)
> Comment on attachment 403238 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403238&action=review
> 
> > Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:53
> > +template<typename CharacterType> static constexpr bool isManifestNewline(CharacterType character)
> 
> This seems like a pretty standard definition of isNewline. Just saying.

You don't know about these newfangled emoji newlines in Unicode 12?

> 
> > Source/WebCore/loader/appcache/ApplicationCacheManifestParser.h:36
> > +    FallbackURLVector fallbackURLs;
> 
> Seems a slight shame that we have to include ApplicationCache.h just to get
> the definition of this vector type.

Yeah. That's silly. Will fix (just not in this rename, too scared of messing up svn add / svn removes right now).

[EWS]

Committed r263775: <https://trac.webkit.org/changeset/263775>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403238 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64959544>

[Darin Adler]

Noticed some "manfest" in the patch instead of "manifest".