Bug 213804 - [ macOS wk2 ] REGRESSION(r263485): fast/scrolling/mac/scroll-snapping-in-progress.html is a flaky failure
Summary: [ macOS wk2 ] REGRESSION(r263485): fast/scrolling/mac/scroll-snapping-in-prog...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-30 11:36 PDT by Jacob Uphoff
Modified: 2020-07-16 09:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2020-07-16 09:24 PDT, Hector Lopez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Uphoff 2020-06-30 11:36:30 PDT 
fast/scrolling/mac/scroll-snapping-in-progress.html

This test has been a flaky failure on macOS wk2 since it was introduced on r263485.

History:

https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Fmac%2Fscroll-snapping-in-progress.html

Diff:

 Sending wheel events
 PASS container.scrollTop > 0 is true
-PASS window.internals.isScrollSnapInProgress(container) is true
+FAIL window.internals.isScrollSnapInProgress(container) should be true. Was false.
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
Comment 1 Radar WebKit Bug Importer 2020-06-30 11:36:59 PDT 
<rdar://problem/64948258>
Comment 2 Simon Fraser (smfr) 2020-06-30 15:35:15 PDT 
I can reproduce.
Comment 3 Simon Fraser (smfr) 2020-06-30 16:04:29 PDT 
Doesn't reproduce when I turn on logging.
Comment 4 Simon Fraser (smfr) 2020-06-30 16:30:06 PDT 
When it flakes, we send the scroll event earlier, so we haven't started the scroll snap timer in ScrollController yet.
Comment 5 Simon Fraser (smfr) 2020-06-30 16:32:45 PDT 
Seem to relate to whether we handle the two wheel events in the same commit, or different commits.
Comment 6 Simon Fraser (smfr) 2020-06-30 16:49:33 PDT 
I don't see a way to make a non-flakey version of this test with the APIs we have. I can't wait for scrolling completion, because scroll snap is something that delays completion. I can't control when scroll events fire relative to wheel events, and I can't use wheel handlers in the test because that sends us down the slow-scrolling path.
Comment 7 Hector Lopez 2020-07-16 09:24:22 PDT 
Created attachment 404448 [details]
Patch
Comment 8 Truitt Savell 2020-07-16 09:28:33 PDT 
Comment on attachment 404448 [details]
Patch

Clearing flags on attachment: 404448

Committed r264460: <https://trac.webkit.org/changeset/264460>