Bug 213766 - Remove WTF::MD5
Summary: Remove WTF::MD5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-29 17:44 PDT by Alex Christensen
Modified: 2020-06-30 10:27 PDT (History)
13 users (show)

See Also:


Attachments
Patch (20.48 KB, patch)
2020-06-29 17:45 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (20.62 KB, patch)
2020-06-29 17:50 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (45.69 KB, patch)
2020-06-29 18:20 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (45.72 KB, patch)
2020-06-29 18:40 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-06-29 17:44:28 PDT
Remove WTF::MD5
Comment 1 Alex Christensen 2020-06-29 17:45:39 PDT
Created attachment 403145 [details]
Patch
Comment 2 Alex Christensen 2020-06-29 17:50:26 PDT
Created attachment 403146 [details]
Patch
Comment 3 Alex Christensen 2020-06-29 18:20:17 PDT
Created attachment 403151 [details]
Patch
Comment 4 Alex Christensen 2020-06-29 18:40:41 PDT
Created attachment 403156 [details]
Patch
Comment 5 youenn fablet 2020-06-30 04:56:18 PDT
Comment on attachment 403156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403156&action=review

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:223
>          baseNameBuilder.append(hex(rawdata[i], Lowercase));

This might break existing network cache. I think that is fine.
If not, I guess CURL port can add back MD5 in CURL specific files.
Comment 6 EWS 2020-06-30 10:26:27 PDT
Committed r263759: <https://trac.webkit.org/changeset/263759>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403156 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-30 10:27:20 PDT
<rdar://problem/64944843>