Bug 213750 - New API benchmark
Summary: New API benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-29 13:30 PDT by Tadeu Zagallo
Modified: 2020-06-29 18:13 PDT (History)
6 users (show)

See Also:


Attachments
Patch (159.51 KB, patch)
2020-06-29 15:02 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff
Patch for landing (160.74 KB, patch)
2020-06-29 16:36 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2020-06-29 13:30:41 PDT
...
Comment 1 Tadeu Zagallo 2020-06-29 15:02:13 PDT
Created attachment 403119 [details]
Patch
Comment 2 Saam Barati 2020-06-29 15:05:29 PDT
Comment on attachment 403119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review

rs=me

> PerformanceTests/APIBench/api-bench:1
> +#!/usr/bin/env bash

too much bash 😰
Comment 3 Saam Barati 2020-06-29 15:08:56 PDT
Comment on attachment 403119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review

> PerformanceTests/ChangeLog:30
> +        Score: 68.7642

this should be time, not score, unless you invert

score implies bigger is better
Comment 4 Saam Barati 2020-06-29 15:14:24 PDT
Comment on attachment 403119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review

> PerformanceTests/ChangeLog:25
> +        RichardsJS: 15ms

it's kind of weird this is part of the score
Comment 5 Tadeu Zagallo 2020-06-29 15:31:26 PDT
Comment on attachment 403119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review

>> PerformanceTests/ChangeLog:25
>> +        RichardsJS: 15ms
> 
> it's kind of weird this is part of the score

I removed this from the score, but kept it being printed here, just as a reference.

>> PerformanceTests/ChangeLog:30
>> +        Score: 68.7642
> 
> this should be time, not score, unless you invert
> 
> score implies bigger is better

I updated the changelog to be clearer, but yeah, it is inverted.
Comment 6 Tadeu Zagallo 2020-06-29 16:36:32 PDT
Created attachment 403133 [details]
Patch for landing
Comment 7 EWS 2020-06-29 18:12:35 PDT
Committed r263712: <https://trac.webkit.org/changeset/263712>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403133 [details].
Comment 8 Radar WebKit Bug Importer 2020-06-29 18:13:22 PDT
<rdar://problem/64917239>