RESOLVED FIXED 213750
New API benchmark 
https://bugs.webkit.org/show_bug.cgi?id=213750
Summary New API benchmark
Tadeu Zagallo
Reported 2020-06-29 13:30:41 PDT
...
Attachments
Patch (159.51 KB, patch)
2020-06-29 15:02 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (160.74 KB, patch)
2020-06-29 16:36 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2020-06-29 15:02:13 PDT
Created attachment 403119 [details] Patch
Saam Barati
Comment 2 2020-06-29 15:05:29 PDT
Comment on attachment 403119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review rs=me > PerformanceTests/APIBench/api-bench:1 > +#!/usr/bin/env bash too much bash 😰
Saam Barati
Comment 3 2020-06-29 15:08:56 PDT
Comment on attachment 403119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review > PerformanceTests/ChangeLog:30 > + Score: 68.7642 this should be time, not score, unless you invert score implies bigger is better
Saam Barati
Comment 4 2020-06-29 15:14:24 PDT
Comment on attachment 403119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review > PerformanceTests/ChangeLog:25 > + RichardsJS: 15ms it's kind of weird this is part of the score
Tadeu Zagallo
Comment 5 2020-06-29 15:31:26 PDT
Comment on attachment 403119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review >> PerformanceTests/ChangeLog:25 >> + RichardsJS: 15ms > > it's kind of weird this is part of the score I removed this from the score, but kept it being printed here, just as a reference. >> PerformanceTests/ChangeLog:30 >> + Score: 68.7642 > > this should be time, not score, unless you invert > > score implies bigger is better I updated the changelog to be clearer, but yeah, it is inverted.
Tadeu Zagallo
Comment 6 2020-06-29 16:36:32 PDT
Created attachment 403133 [details] Patch for landing
EWS
Comment 7 2020-06-29 18:12:35 PDT
Committed r263712: <https://trac.webkit.org/changeset/263712> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403133 [details].
Radar WebKit Bug Importer
Comment 8 2020-06-29 18:13:22 PDT
<rdar://problem/64917239>
Note You need to log in before you can comment on or make changes to this bug.