...
Created attachment 403119 [details] Patch
Comment on attachment 403119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review rs=me > PerformanceTests/APIBench/api-bench:1 > +#!/usr/bin/env bash too much bash 😰
Comment on attachment 403119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review > PerformanceTests/ChangeLog:30 > + Score: 68.7642 this should be time, not score, unless you invert score implies bigger is better
Comment on attachment 403119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review > PerformanceTests/ChangeLog:25 > + RichardsJS: 15ms it's kind of weird this is part of the score
Comment on attachment 403119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403119&action=review >> PerformanceTests/ChangeLog:25 >> + RichardsJS: 15ms > > it's kind of weird this is part of the score I removed this from the score, but kept it being printed here, just as a reference. >> PerformanceTests/ChangeLog:30 >> + Score: 68.7642 > > this should be time, not score, unless you invert > > score implies bigger is better I updated the changelog to be clearer, but yeah, it is inverted.
Created attachment 403133 [details] Patch for landing
Committed r263712: <https://trac.webkit.org/changeset/263712> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403133 [details].
<rdar://problem/64917239>