Bug 213749 - [WPE][GTK] Update stale comment in UserAgentGLib.cpp
Summary: [WPE][GTK] Update stale comment in UserAgentGLib.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-29 13:16 PDT by Michael Catanzaro
Modified: 2020-06-30 03:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2020-06-29 13:17 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-06-29 13:16:07 PDT
Update stale comment in UserAgentGLib.cpp, the macOS version string is no longer frozen since r228334
Comment 1 Michael Catanzaro 2020-06-29 13:17:27 PDT
Created attachment 403103 [details]
Patch
Comment 2 Adrian Perez 2020-06-30 02:55:23 PDT
Comment on attachment 403103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403103&action=review

> Source/WebCore/platform/glib/UserAgentGLib.cpp:-67
> -    // Version is frozen per https://bugs.webkit.org/show_bug.cgi?id=180365

Probably some years down the road we will need to claim to be “ARM macOS 11_x_y” 😓️
Life was so much easier with the Mac version being frozen…
Comment 3 EWS 2020-06-30 03:19:45 PDT
Committed r263738: <https://trac.webkit.org/changeset/263738>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403103 [details].