Bug 213722 - [MSE][GStreamer] Rename MediaSourceGStreamer to MediaSourcePrivateGStreamer
Summary: [MSE][GStreamer] Rename MediaSourceGStreamer to MediaSourcePrivateGStreamer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-29 03:26 PDT by Alicia Boya García
Modified: 2020-06-29 04:50 PDT (History)
16 users (show)

See Also:

Attachments
Patch (32.40 KB, patch)
2020-06-29 03:27 PDT, Alicia Boya García 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2020-06-29 03:26:17 PDT 
It's about time to remove this FIXME:

// FIXME: Should this be called MediaSourcePrivateGStreamer?

Yes, it should. Because it's a MediaSourcePrivate, and that is an
important fact. The MSE class diagram is confusing enough already,
let's fix this.

To rebase commits after this change use `git format-patch` first to
get them in a patch format and then run:

sed -i 's|\<MediaSourceGStreamer\>|MediaSourcePrivateGStreamer|g' *.patch

This patch is a refactor that produces no behavior changes.
Comment 1 Alicia Boya García 2020-06-29 03:27:44 PDT 
Created attachment 403047 [details]
Patch
Comment 2 EWS 2020-06-29 04:50:24 PDT 
Committed r263656: <https://trac.webkit.org/changeset/263656>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403047 [details].