Bug 213694 - [GTK] [Win] Build callOnMainThread on WTF::RunLoop rather than on a timer
Summary: [GTK] [Win] Build callOnMainThread on WTF::RunLoop rather than on a timer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-27 22:16 PDT by Geoffrey Garen
Modified: 2020-06-29 22:33 PDT (History)
9 users (show)

See Also:


Attachments
Patch (4.69 KB, patch)
2020-06-27 22:17 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (4.86 KB, patch)
2020-06-27 22:21 PDT, Geoffrey Garen
cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (5.70 KB, patch)
2020-06-29 20:52 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch for landing 2 (1.17 KB, patch)
2020-06-29 21:50 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2020-06-27 22:16:25 PDT
[GTK] [Win] Build callOnMainThread on WTF::RunLoop rather than on a timer
Comment 1 Geoffrey Garen 2020-06-27 22:17:04 PDT
Created attachment 402986 [details]
Patch
Comment 2 Geoffrey Garen 2020-06-27 22:21:16 PDT
Created attachment 402987 [details]
Patch
Comment 3 Carlos Garcia Campos 2020-06-29 00:19:18 PDT
Comment on attachment 402987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402987&action=review

> Source/WTF/wtf/glib/RunLoopSourcePriority.h:-53
> -    // callOnMainThread.
> -    MainThreadDispatcherTimer = 100,
> -

You should remove the WPE definition below too.
Comment 4 Geoffrey Garen 2020-06-29 20:52:56 PDT
Created attachment 403169 [details]
Patch for landing
Comment 5 EWS 2020-06-29 21:25:55 PDT
Committed r263723: <https://trac.webkit.org/changeset/263723>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403169 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-29 21:26:17 PDT
<rdar://problem/64922555>
Comment 7 Geoffrey Garen 2020-06-29 21:50:56 PDT
Reopening to attach new patch.
Comment 8 Geoffrey Garen 2020-06-29 21:50:57 PDT
Created attachment 403173 [details]
Patch for landing 2
Comment 9 EWS 2020-06-29 22:33:41 PDT
Committed r263726: <https://trac.webkit.org/changeset/263726>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403173 [details].