Bug 213687 - findGCObjectPointersForMarking may have optimization opportunities
Summary: findGCObjectPointersForMarking may have optimization opportunities
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-27 16:47 PDT by Keith Miller
Modified: 2020-06-27 16:47 PDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-06-27 16:47:07 PDT
https://bugs.webkit.org/show_bug.cgi?id=213686 indicated it was a 2% perf regression on Speedo2 and JetStream2 to not return early from findGCObjectPointersForMarking after finding a live pointer to some HeapKind::JSCell. Likely, that regression comes from trying to determine if the pointer was live. It's possible most of this is from checking if the different pointers are live. 

Some improvements could be specializing findGCObjectPointersForMarking on the HeapKind or passing all values simultaneously to MarkedBlock::isLive.