Video spills over PiP screen a little when using Picture in Picture
<rdar://problem/64747869>
Created attachment 402932 [details] Patch
Comment on attachment 402932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402932&action=review > Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:986 > + FloatSize videoDimensions = FloatSize(videoElement.videoWidth(), videoElement.videoHeight()); > + > + dispatch_async(dispatch_get_main_queue(), [protectedThis = makeRefPtr(this), this, videoElementClientRect, videoDimensions, viewRef, mode, allowsPictureInPicture] { Can you use something like this instead - FloatSize videoDimensions = { videoElement.videoWidth(), videoElement.videoHeight() }
Comment on attachment 402932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402932&action=review >> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:986 >> + dispatch_async(dispatch_get_main_queue(), [protectedThis = makeRefPtr(this), this, videoElementClientRect, videoDimensions, viewRef, mode, allowsPictureInPicture] { > > Can you use something like this instead - FloatSize videoDimensions = { videoElement.videoWidth(), videoElement.videoHeight() } Good idea! I change it to: FloatSize videoDimensions = { (float)videoElement.videoWidth(), (float)videoElement.videoHeight() };
Created attachment 403081 [details] patch for landing
Committed r263707: <https://trac.webkit.org/changeset/263707> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403081 [details].