RESOLVED FIXED 213636
WKHTTPCookieStore.setCookie should flush the cookies to disk before calling completion handler when we are using the UIProcess's default cookie storage 
https://bugs.webkit.org/show_bug.cgi?id=213636
Summary WKHTTPCookieStore.setCookie should flush the cookies to disk before calling c...
Alex Christensen
Reported 2020-06-25 20:58:59 PDT
WKHTTPCookieStore.setCookie should flush the cookies to disk before calling completion handler when we are using the UIProcess's default cookie storage
Attachments
Patch (6.80 KB, patch)
2020-06-25 20:59 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-06-25 20:59:53 PDT
Created attachment 402847 [details] Patch
EWS
Comment 2 2020-06-25 21:36:24 PDT
Committed r263551: <https://trac.webkit.org/changeset/263551> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402847 [details].
Radar WebKit Bug Importer
Comment 3 2020-06-25 21:37:13 PDT
<rdar://problem/64789854>
Alex Christensen
Comment 4 2020-08-14 18:04:42 PDT
Comment on attachment 402847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402847&action=review > Source/WebKit/UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:42 > + ASSERT(RunLoop::isMain()); > + [[NSHTTPCookieStorage sharedHTTPCookieStorage] _saveCookies:makeBlockPtr([completionHandler = WTFMove(completionHandler)]() mutable { This being on the main thread caused hangs which I believe were resolved with http://trac.webkit.org/r264613
Alex Christensen
Comment 5 2020-08-14 18:44:23 PDT
Reverting in https://bugs.webkit.org/show_bug.cgi?id=215530
Note You need to log in before you can comment on or make changes to this bug.