Bug 213630 – Upstream date/time picker style

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Upstream date/time picker style

[Megan Gardner]

Created attachment 402830 [details]
Patch

[Wenson Hsieh]

Comment on attachment 402830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102
> +    return UIDatePickerStyleInline;

This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).

[Megan Gardner]

Comment on attachment 402830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review

>> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102
>> +    return UIDatePickerStyleInline;
> 
> This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).

It is at the call site, but I can add more guards if that seems prudent.

[Wenson Hsieh]

(In reply to Megan Gardner from comment #3)
> Comment on attachment 402830 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402830&action=review
> 
> >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102
> >> +    return UIDatePickerStyleInline;
> > 
> > This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).
> 
> It is at the call site, but I can add more guards if that seems prudent.

(To clarify — this needs to be guarded in order to fix the iOS 13.4 build)

[Megan Gardner]

Created attachment 402840 [details]
Patch

[Megan Gardner]

Comment on attachment 402830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review

>>>> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102
>>>> +    return UIDatePickerStyleInline;
>>> 
>>> This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).
>> 
>> It is at the call site, but I can add more guards if that seems prudent.
> 
> (To clarify — this needs to be guarded in order to fix the iOS 13.4 build)

yes... I see that now...

[Megan Gardner]

Created attachment 402842 [details]
Patch for landing

[EWS]

Committed r263549: <https://trac.webkit.org/changeset/263549>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402842 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64787064>