Bug 213630 - Upstream date/time picker style
Summary: Upstream date/time picker style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-25 17:22 PDT by Megan Gardner
Modified: 2020-06-25 19:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2020-06-25 17:27 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2020-06-25 18:25 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.90 KB, patch)
2020-06-25 19:25 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-06-25 17:22:32 PDT 
Upstream date/time picker style
Comment 1 Megan Gardner 2020-06-25 17:27:30 PDT 
Created attachment 402830 [details]
Patch
Comment 2 Wenson Hsieh 2020-06-25 17:54:57 PDT 
Comment on attachment 402830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102
> +    return UIDatePickerStyleInline;

This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).
Comment 3 Megan Gardner 2020-06-25 18:23:03 PDT 
Comment on attachment 402830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review

>> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102
>> +    return UIDatePickerStyleInline;
> 
> This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).

It is at the call site, but I can add more guards if that seems prudent.
Comment 4 Wenson Hsieh 2020-06-25 18:25:50 PDT 
(In reply to Megan Gardner from comment #3)
> Comment on attachment 402830 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402830&action=review
> 
> >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102
> >> +    return UIDatePickerStyleInline;
> > 
> > This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).
> 
> It is at the call site, but I can add more guards if that seems prudent.

(To clarify — this needs to be guarded in order to fix the iOS 13.4 build)
Comment 5 Megan Gardner 2020-06-25 18:25:53 PDT 
Created attachment 402840 [details]
Patch
Comment 6 Megan Gardner 2020-06-25 18:28:25 PDT 
Comment on attachment 402830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review

>>>> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102
>>>> +    return UIDatePickerStyleInline;
>>> 
>>> This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).
>> 
>> It is at the call site, but I can add more guards if that seems prudent.
> 
> (To clarify — this needs to be guarded in order to fix the iOS 13.4 build)

yes... I see that now...
Comment 7 Megan Gardner 2020-06-25 19:25:34 PDT 
Created attachment 402842 [details]
Patch for landing
Comment 8 EWS 2020-06-25 19:47:20 PDT 
Committed r263549: <https://trac.webkit.org/changeset/263549>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402842 [details].
Comment 9 Radar WebKit Bug Importer 2020-06-25 19:48:14 PDT 
<rdar://problem/64787064>