Web Inspector: Allow selecting text of Response (DOM Tree)

[Nikita Vasilyev]

Steps:
0. Open https://webkit.org
1. Open Web Inspector
2. Open Network, select webkit.org
3. On the top right side, change "Response" to "Response (DOM Tree)"
4. Try selecting text in the content view. It doesn't work.

[Nikita Vasilyev]

Created attachment 402806 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 402806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402806&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:50
> +.tree-outline.dom.non-selectable {

Should we allow selecting text of something with a class "non-selectable"? Should that class just be removed?

[Nikita Vasilyev]

Created attachment 402812 [details]
[Video] With patch applied

I see "non-selectable" was added for this new case that is different from TreeOutline selection in Elements. In Elements, it isn't text selection. It's treeOutline node selection, which is different.

I hope it clears things up.

[Nikita Vasilyev]

(In reply to Joseph Pecoraro from comment #2)
> Comment on attachment 402806 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402806&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:50
> > +.tree-outline.dom.non-selectable {
> 
> Should we allow selecting text of something with a class "non-selectable"?
> Should that class just be removed?

To answer your question:

No, because in Elements, we don't have "non-selectable" and it should not have `-webkit-user-select: text`.

[Joseph Pecoraro]

Comment on attachment 402806 [details]
Patch

Sounds fine then.

[EWS]

Committed r263872: <https://trac.webkit.org/changeset/263872>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402806 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65054055>