Bug 213614 - [JHBuild] Add support for using a minimal moduleset
Summary: [JHBuild] Add support for using a minimal moduleset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-25 12:37 PDT by Carlos Alberto Lopez Perez
Modified: 2021-10-08 05:16 PDT (History)
12 users (show)

See Also:


Attachments
Patch (14.81 KB, patch)
2020-06-25 12:45 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (15.62 KB, patch)
2020-07-07 08:54 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-06-25 12:37:08 PDT
We would like to be able to build WebKit on a given distribution using as much libraries from the system as possible.
So the idea is to have a minimum JHBuild moduleset for building only the libraries that are not available on the distribution.
Comment 1 Carlos Alberto Lopez Perez 2020-06-25 12:45:33 PDT
Created attachment 402796 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-06-27 01:17:06 PDT
Comment on attachment 402796 [details]
Patch

I think there's an option in jhbuild to prefer system modules when the version is newer than the one in the moduleset.
Comment 3 Carlos Alberto Lopez Perez 2020-07-07 08:45:39 PDT
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 402796 [details]
> Patch
> 
> I think there's an option in jhbuild to prefer system modules when the
> version is newer than the one in the moduleset.

Right. But AFAIK that doesn't work for what I intend to do here.

AFAIK <systemmodule ...> tells JHBuild that the dependency should be installed by the system (distro package), and if is not installed then JHBuild will fail. In other words: with systemmodule, jhbuild won't build the dependency if the system doesn't provide one new enough. It will simply fail.

What I'm trying to do here is to tell JHBuild to check if the system provides a new enough version of the dependency, and if it does then skip building it. If it doesn't then JHBuild will build it, instead of failing.

This is achieved by using the <pkg-config> directive in the modules
Comment 4 Carlos Alberto Lopez Perez 2020-07-07 08:54:05 PDT
Created attachment 403692 [details]
Patch
Comment 5 EWS 2020-07-08 03:41:58 PDT
Committed r264092: <https://trac.webkit.org/changeset/264092>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403692 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-08 03:42:14 PDT
<rdar://problem/65217427>