WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 213602
fast/dynamic/window-resize-scrollbars-test.html is no longer failing - remove expectations
https://bugs.webkit.org/show_bug.cgi?id=213602
Summary
fast/dynamic/window-resize-scrollbars-test.html is no longer failing - remove...
Karl Rackler
Reported
2020-06-25 07:48:04 PDT
fast/dynamic/window-resize-scrollbars-test.html is no longer failing - remove expectations Current history is green:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fdynamic%2Fwindow-resize-scrollbars-test.html
Attachments
Patch
(1.62 KB, patch)
2020-06-25 07:50 PDT
,
Karl Rackler
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Karl Rackler
Comment 1
2020-06-25 07:50:09 PDT
Created
attachment 402734
[details]
Patch
EWS
Comment 2
2020-06-25 08:04:36 PDT
Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 53, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'
EWS
Comment 3
2020-06-25 09:49:19 PDT
Invalid ChangeLog at /Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog
EWS
Comment 4
2020-06-25 09:52:14 PDT
tsavell@apple.com
does not have reviewer permissions according to
https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json
. Rejecting
attachment 402734
[details]
from commit queue.
Truitt Savell
Comment 5
2020-06-25 09:59:33 PDT
Comment on
attachment 402734
[details]
Patch Clearing flags on attachment: 402734 Committed
r263515
: <
https://trac.webkit.org/changeset/263515
>
Radar WebKit Bug Importer
Comment 6
2020-06-25 17:06:17 PDT
<
rdar://problem/64781354
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug