Bug 213596 – [GTK][WPE] Add webkit_authentication_request_get_security_origin

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

I'm not sure if we should deprecate get_port and get_host, they are convenient to avoid creating a security origin when you just want to get the host, for example.

[Carlos Garcia Campos]

Created attachment 402727 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 402727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402727&action=review

> Source/WebKit/UIProcess/API/glib/WebKitAuthenticationRequest.cpp:368
> +    return webkitSecurityOriginCreate(SecurityOrigin::create(protocol, protectionSpace.host(), protectionSpace.port()));

You could ASSERT(!protocol.isEmpty()) here, just in case. webkitSecurityOriginCreate really will allow creating an invalid WebKitSecurityOrigin with empty protocol.

> Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationRequest.h:30
>  #include <webkit2/WebKitCredential.h>
> +#include <webkit2/WebKitSecurityOrigin.h>
>  #include <webkit2/WebKitDefines.h>

It's misalphabetized.

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 402727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402727&action=review
> 
> > Source/WebKit/UIProcess/API/glib/WebKitAuthenticationRequest.cpp:368
> > +    return webkitSecurityOriginCreate(SecurityOrigin::create(protocol, protectionSpace.host(), protectionSpace.port()));
> 
> You could ASSERT(!protocol.isEmpty()) here, just in case.
> webkitSecurityOriginCreate really will allow creating an invalid
> WebKitSecurityOrigin with empty protocol.

How can it be empty if it's set to a literal in a switch handling al possible cases?

> > Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationRequest.h:30
> >  #include <webkit2/WebKitCredential.h>
> > +#include <webkit2/WebKitSecurityOrigin.h>
> >  #include <webkit2/WebKitDefines.h>
> 
> It's misalphabetized.

[Carlos Garcia Campos]

Committed r263645: <https://trac.webkit.org/changeset/263645>