Starting to implement CSS filters using CoreImage to accelerate. This patch contains the necessary building blocks that guards new implementations using a feature flag.
<rdar://problem/64724629>
Created attachment 402693 [details] Patch
Comment on attachment 402693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402693&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:338 > +ENABLE_ACCELERATED_FILTER_RENDER = ENABLE_ACCELERATED_FILTER_RENDER; There is no need to add new features to FeatureDefines.xcconfig. Just put them in PlatformEnableCocoa.h instead.
Comment on attachment 402693 [details] Patch red red red red red red red red red red red red red red red red red red red
Created attachment 402714 [details] Patch
Comment on attachment 402714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402714&action=review > Source/WTF/wtf/PlatformUse.h:62 > +#define USE_CI 1 Please call this USE_CORE_IMAGE. CI is very ambiguous.
Created attachment 402715 [details] Patch
Comment on attachment 402715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402715&action=review Looks OK > Source/WTF/wtf/PlatformUse.h:63 > +#if PLATFORM(COCOA) > +#define USE_CORE_IMAGE 1 > +#endif There’s already CoreImage usage in WebKit. I’m not sure how we’re going to use this going forward, and if maybe we should be using it on existing code instead of what it’s currently doing?
Created attachment 402827 [details] Patch
Created attachment 402892 [details] Patch
Committed r263718: <https://trac.webkit.org/changeset/263718> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402892 [details].
Comment on attachment 402892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402892&action=review > Source/WebKit/Shared/WebPreferences.yaml:2049 > +CoreImageAcceleratedFilterRenderEnabled: I would have called this CoreImageAcceleratedFilterRenderingEnabled or CoreImageAcceleratedFiltersEnabled