RESOLVED FIXED 213578
Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters 
https://bugs.webkit.org/show_bug.cgi?id=213578
Summary Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
frankhome61
Reported 2020-06-24 15:32:18 PDT
Starting to implement CSS filters using CoreImage to accelerate. This patch contains the necessary building blocks that guards new implementations using a feature flag.
Attachments
Patch (53.57 KB, patch)
2020-06-24 16:10 PDT, frankhome61 		no flags
DetailsFormatted DiffDiff
Patch (6.57 KB, patch)
2020-06-24 21:16 PDT, frankhome61 		no flags
DetailsFormatted DiffDiff
Patch (6.58 KB, patch)
2020-06-24 21:34 PDT, frankhome61 		no flags
DetailsFormatted DiffDiff
Patch (6.70 KB, patch)
2020-06-25 16:33 PDT, frankhome61 		no flags
DetailsFormatted DiffDiff
Patch (6.80 KB, patch)
2020-06-26 13:09 PDT, frankhome61 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-24 15:33:14 PDT
<rdar://problem/64724629>
frankhome61
Comment 2 2020-06-24 16:10:34 PDT
Created attachment 402693 [details] Patch
Darin Adler
Comment 3 2020-06-24 17:19:06 PDT
Comment on attachment 402693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402693&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:338 > +ENABLE_ACCELERATED_FILTER_RENDER = ENABLE_ACCELERATED_FILTER_RENDER; There is no need to add new features to FeatureDefines.xcconfig. Just put them in PlatformEnableCocoa.h instead.
Darin Adler
Comment 4 2020-06-24 17:19:07 PDT
Comment on attachment 402693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402693&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:338 > +ENABLE_ACCELERATED_FILTER_RENDER = ENABLE_ACCELERATED_FILTER_RENDER; There is no need to add new features to FeatureDefines.xcconfig. Just put them in PlatformEnableCocoa.h instead.
Myles C. Maxfield
Comment 5 2020-06-24 21:09:13 PDT
Comment on attachment 402693 [details] Patch red red red red red red red red red red red red red red red red red red red
frankhome61
Comment 6 2020-06-24 21:16:13 PDT
Created attachment 402714 [details] Patch
Simon Fraser (smfr)
Comment 7 2020-06-24 21:20:53 PDT
Comment on attachment 402714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402714&action=review > Source/WTF/wtf/PlatformUse.h:62 > +#define USE_CI 1 Please call this USE_CORE_IMAGE. CI is very ambiguous.
frankhome61
Comment 8 2020-06-24 21:34:26 PDT
Created attachment 402715 [details] Patch
Darin Adler
Comment 9 2020-06-25 10:05:45 PDT
Comment on attachment 402715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402715&action=review Looks OK > Source/WTF/wtf/PlatformUse.h:63 > +#if PLATFORM(COCOA) > +#define USE_CORE_IMAGE 1 > +#endif There’s already CoreImage usage in WebKit. I’m not sure how we’re going to use this going forward, and if maybe we should be using it on existing code instead of what it’s currently doing?
frankhome61
Comment 10 2020-06-25 16:33:16 PDT
Created attachment 402827 [details] Patch
frankhome61
Comment 11 2020-06-26 13:09:39 PDT
Created attachment 402892 [details] Patch
EWS
Comment 12 2020-06-29 18:59:33 PDT
Committed r263718: <https://trac.webkit.org/changeset/263718> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402892 [details].
Simon Fraser (smfr)
Comment 13 2020-06-30 09:30:54 PDT
Comment on attachment 402892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402892&action=review > Source/WebKit/Shared/WebPreferences.yaml:2049 > +CoreImageAcceleratedFilterRenderEnabled: I would have called this CoreImageAcceleratedFilterRenderingEnabled or CoreImageAcceleratedFiltersEnabled
Note You need to log in before you can comment on or make changes to this bug.