Bug 213575 - Access to AXIsolatedTree:m_readerThreadNodeMap should happen only on the secondary AX thread.
Summary: Access to AXIsolatedTree:m_readerThreadNodeMap should happen only on the seco...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-24 14:19 PDT by Andres Gonzalez
Modified: 2020-06-26 12:43 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.62 KB, patch)
2020-06-24 14:33 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-06-24 14:19:18 PDT 
Access to AXIsolatedTree:m_readerThreadNodeMap should happen only on the secondary AX thread.
Comment 1 Andres Gonzalez 2020-06-24 14:33:13 PDT 
Created attachment 402687 [details]
Patch
Comment 2 EWS 2020-06-26 12:20:10 PDT 
Committed r263572: <https://trac.webkit.org/changeset/263572>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402687 [details].
Comment 3 Radar WebKit Bug Importer 2020-06-26 12:21:24 PDT 
<rdar://problem/64817078>
Comment 4 Darin Adler 2020-06-26 12:43:16 PDT 
Comment on attachment 402687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402687&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:109
> +    void updateChildrenIDs(AXID axID, Vector<AXID>&& childrenIDs);

WebKit coding style discourages including names like "axID" that just repeat the name of the type, when declaring a function. This was a pre-existing thing that we just moved, but something to avoid in future.

Seems like a minor bug in the style checking script that it didn’t detect this — I know it has code that attempts to do it, but maybe the upper/lowercase confuses it.