Bug 213572 - REGRESSION (r260276): Scrolling through shelves on music.apple.com is not smooth
Summary: REGRESSION (r260276): Scrolling through shelves on music.apple.com is not smooth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-24 13:36 PDT by Simon Fraser (smfr)
Modified: 2020-06-26 09:16 PDT (History)
17 users (show)

See Also:

Attachments
Patch (27.53 KB, patch)
2020-06-24 13:49 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-06-24 13:36:16 PDT 
REGRESSION (r260276): Scrolling through shelves on music.apple.com is not smooth
Comment 1 Simon Fraser (smfr) 2020-06-24 13:49:59 PDT 
Created attachment 402681 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-06-24 13:50:02 PDT 
<rdar://problem/64306590>
Comment 3 Wenson Hsieh 2020-06-24 13:57:01 PDT 
Comment on attachment 402681 [details]
Patch

r=mews
Comment 4 EWS 2020-06-24 16:58:35 PDT 
Committed r263485: <https://trac.webkit.org/changeset/263485>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402681 [details].
Comment 5 Truitt Savell 2020-06-26 09:16:48 PDT 
The new test: fast/scrolling/mac/scroll-snapping-in-progress.html
added in https://trac.webkit.org/changeset/263485/webkit

is a flaky failure on Mojave wk2. History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Fmac%2Fscroll-snapping-in-progress.html

Diff:
--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/scrolling/mac/scroll-snapping-in-progress-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/scrolling/mac/scroll-snapping-in-progress-actual.txt
@@ -4,8 +4,9 @@
 
 Sending wheel events
 PASS container.scrollTop > 0 is true
-PASS window.internals.isScrollSnapInProgress(container) is true
+FAIL window.internals.isScrollSnapInProgress(container) should be true. Was false.
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE