Bug 213571 - No scrolling momentum with 'scroll-snap-type: x mandatory' if the scroller scrolls vertically
Summary: No scrolling momentum with 'scroll-snap-type: x mandatory' if the scroller sc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks: 218115
  Show dependency treegraph
 
Reported: 2020-06-24 12:40 PDT by Simon Fraser (smfr)
Modified: 2021-03-23 01:52 PDT (History)
4 users (show)

See Also:


Attachments
Testcase (2.14 KB, text/html)
2020-06-24 12:40 PDT, Simon Fraser (smfr)
no flags Details
Patch (7.24 KB, patch)
2021-03-19 07:04 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (12.94 KB, patch)
2021-03-19 11:21 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (6.63 KB, patch)
2021-03-19 11:25 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (6.66 KB, patch)
2021-03-20 05:20 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-06-24 12:40:16 PDT
Created attachment 402673 [details]
Testcase

In the attached testcase, there is no vertical scrolling momentum in Safari. There is in Firefox.
Comment 1 Radar WebKit Bug Importer 2020-06-24 12:40:39 PDT
<rdar://problem/64715507>
Comment 2 Radar WebKit Bug Importer 2020-06-24 12:40:40 PDT
<rdar://problem/64715506>
Comment 3 Simon Fraser (smfr) 2021-03-10 10:56:08 PST
Seen with https://slides.oddbird.net/csswg/f2f2102/#slide-26
Comment 4 Martin Robinson 2021-03-19 07:04:04 PDT
Created attachment 423727 [details]
Patch
Comment 5 Simon Fraser (smfr) 2021-03-19 09:27:23 PDT
Comment on attachment 423727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423727&action=review

> LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-momentum-in-non-snapping-axis.html:34
> +            } catch (e) {
> +                console.log(e);

Is this necessary?
Comment 6 Martin Robinson 2021-03-19 11:21:21 PDT
Created attachment 423751 [details]
Patch
Comment 7 Martin Robinson 2021-03-19 11:23:06 PDT
(In reply to Simon Fraser (smfr) from comment #5)
> > LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-momentum-in-non-snapping-axis.html:34
> > +            } catch (e) {
> > +                console.log(e);
> 
> Is this necessary?

Unfortunately this is because Promises will otherwise eat exceptions and they won't be printed in test output.
Comment 8 Martin Robinson 2021-03-19 11:25:42 PDT
Created attachment 423752 [details]
Patch
Comment 9 Martin Robinson 2021-03-20 05:20:58 PDT
Created attachment 423816 [details]
Patch
Comment 10 EWS 2021-03-23 01:52:16 PDT
Committed r274853: <https://commits.webkit.org/r274853>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423816 [details].