Bug 213571 – No scrolling momentum with 'scroll-snap-type: x mandatory' if the scroller scrolls vertically

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Simon Fraser (smfr)]

Created attachment 402673 [details]
Testcase

In the attached testcase, there is no vertical scrolling momentum in Safari. There is in Firefox.

[Radar WebKit Bug Importer]

<rdar://problem/64715507>

[Radar WebKit Bug Importer]

<rdar://problem/64715506>

[Simon Fraser (smfr)]

Seen with https://slides.oddbird.net/csswg/f2f2102/#slide-26

[Martin Robinson]

Created attachment 423727 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 423727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423727&action=review

> LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-momentum-in-non-snapping-axis.html:34
> +            } catch (e) {
> +                console.log(e);

Is this necessary?

[Martin Robinson]

Created attachment 423751 [details]
Patch

[Martin Robinson]

(In reply to Simon Fraser (smfr) from comment #5)
> > LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-momentum-in-non-snapping-axis.html:34
> > +            } catch (e) {
> > +                console.log(e);
> 
> Is this necessary?

Unfortunately this is because Promises will otherwise eat exceptions and they won't be printed in test output.

[Martin Robinson]

Created attachment 423752 [details]
Patch

[Martin Robinson]

Created attachment 423816 [details]
Patch

[EWS]

Committed r274853: <https://commits.webkit.org/r274853>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423816 [details].