Bug 213570 - Black rectangle appears when closing PIP on iPhone
Summary: Black rectangle appears when closing PIP on iPhone
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-24 12:06 PDT by Peng Liu
Modified: 2020-06-24 19:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2020-06-24 13:23 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-06-24 12:06:08 PDT 
Black rectangle appears when closing PIP on iPhone
Comment 1 Peng Liu 2020-06-24 12:06:51 PDT 
<rdar://problem/62963556>
Comment 2 Peng Liu 2020-06-24 13:23:29 PDT 
Created attachment 402678 [details]
Patch
Comment 3 Eric Carlson 2020-06-24 13:49:03 PDT 
Comment on attachment 402678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402678&action=review

> Source/WebCore/ChangeLog:10
> +        Don't unhide the window and view of WebAVPlayerViewController before exiting Picture-in-Picture.

I think it is worth saying where m_window will be made visible, e.g. "... before exiting Picture-in-Picture because m_window will be shown ..."
Comment 4 Peng Liu 2020-06-24 15:28:00 PDT 
Comment on attachment 402678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402678&action=review

>> Source/WebCore/ChangeLog:10
>> +        Don't unhide the window and view of WebAVPlayerViewController before exiting Picture-in-Picture.
> 
> I think it is worth saying where m_window will be made visible, e.g. "... before exiting Picture-in-Picture because m_window will be shown ..."

Thanks for the review!
Actually both m_window and m_playerViewController will be destroyed after exiting picture-in-picture. So I think we don't need to show them before destroying them unless there is some animation issue (I haven't found any issue in tests yet).
Comment 5 EWS 2020-06-24 19:11:59 PDT 
Committed r263492: <https://trac.webkit.org/changeset/263492>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402678 [details].