Bug 21357 - DragImage should not depend on Frame and CachedImage
Summary: DragImage should not depend on Frame and CachedImage
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 21354
  Show dependency treegraph
 
Reported: 2008-10-03 22:08 PDT by Sam Weinig
Modified: 2018-05-26 19:23 PDT (History)
12 users (show)

See Also:


Attachments
Patch (14.83 KB, patch)
2013-04-07 04:58 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-10-03 22:08:06 PDT
It is a layering violation for DragImage to depend on Frame and CachedImage.
Comment 1 Carlos Garcia Campos 2013-04-07 04:58:34 PDT
Created attachment 196780 [details]
Patch
Comment 2 WebKit Review Bot 2013-04-07 07:01:53 PDT
Attachment 196780 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Clipboard.h', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/platform/DragImage.cpp', u'Source/WebCore/platform/DragImage.h', u'Source/WebCore/platform/blackberry/DragImageBlackBerry.cpp', u'Source/WebCore/platform/efl/DragImageEfl.cpp', u'Source/WebCore/platform/gtk/DragImageGtk.cpp', u'Source/WebCore/platform/mac/DragImageMac.mm', u'Source/WebCore/platform/qt/DragImageQt.cpp', u'Source/WebCore/platform/win/DragImageWin.cpp', u'Source/WebCore/platform/wx/DragImageWx.cpp']" exit_code: 1
Source/WebCore/dom/Clipboard.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2013-04-08 06:34:00 PDT
Committed r147912: <http://trac.webkit.org/changeset/147912>
Comment 4 Roger Fong 2013-04-08 14:20:40 PDT
http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47197/steps/compile-webkit/logs/stdio

EWS bots are a bit unhappy right now sry :/
Comment 5 Carlos Garcia Campos 2013-04-08 23:29:46 PDT
(In reply to comment #4)
> http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47197/steps/compile-webkit/logs/stdio
> 
> EWS bots are a bit unhappy right now sry :/

Ooops, I'm sorry, thanks for fixing it.
Comment 6 Carlos Garcia Campos 2014-09-17 03:06:55 PDT
hmm, it seems this layering violation was re-introduced in r159455, reopening.