Bug 21357 – DragImage should not depend on Frame and CachedImage

• Status: REOPENED
• Component: Platform

[Sam Weinig]

It is a layering violation for DragImage to depend on Frame and CachedImage.

[Carlos Garcia Campos]

Created attachment 196780 [details]
Patch

[WebKit Review Bot]

Attachment 196780 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Clipboard.h', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/platform/DragImage.cpp', u'Source/WebCore/platform/DragImage.h', u'Source/WebCore/platform/blackberry/DragImageBlackBerry.cpp', u'Source/WebCore/platform/efl/DragImageEfl.cpp', u'Source/WebCore/platform/gtk/DragImageGtk.cpp', u'Source/WebCore/platform/mac/DragImageMac.mm', u'Source/WebCore/platform/qt/DragImageQt.cpp', u'Source/WebCore/platform/win/DragImageWin.cpp', u'Source/WebCore/platform/wx/DragImageWx.cpp']" exit_code: 1
Source/WebCore/dom/Clipboard.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Committed r147912: <http://trac.webkit.org/changeset/147912>

[Roger Fong]

http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47197/steps/compile-webkit/logs/stdio

EWS bots are a bit unhappy right now sry :/

[Carlos Garcia Campos]

(In reply to comment #4)
> http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47197/steps/compile-webkit/logs/stdio
> 
> EWS bots are a bit unhappy right now sry :/

Ooops, I'm sorry, thanks for fixing it.

[Carlos Garcia Campos]

hmm, it seems this layering violation was re-introduced in r159455, reopening.