Bug 213531 - Web Inspector: add a tooltip to the icon of overridden resources to clarify meaning
Summary: Web Inspector: add a tooltip to the icon of overridden resources to clarify m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-23 14:02 PDT by Devin Rousso
Modified: 2020-06-23 16:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (22.54 KB, patch)
2020-06-23 14:06 PDT, Devin Rousso 		bburg: review+
Details | Formatted Diff | Diff
Patch (22.55 KB, patch)
2020-06-23 15:54 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-06-23 14:02:42 PDT 
The inverted icon is not immediately explanatory (although it is quickly identifiable), so we should add a `title` to provide it.
Comment 1 Devin Rousso 2020-06-23 14:06:51 PDT 
Created attachment 402589 [details]
Patch
Comment 2 BJ Burg 2020-06-23 15:43:52 PDT 
Comment on attachment 402589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402589&action=review

r=me

> Source/WebInspectorUI/ChangeLog:30
> +        Add a `title` to the overriden resource icon that clarifies the fact that the resource was

Nit: overridden

> Source/WebInspectorUI/UserInterface/Views/DataGridNode.js:410
> +        // Subclasses may override

Nit: trailing period
Comment 3 Devin Rousso 2020-06-23 15:54:58 PDT 
Created attachment 402601 [details]
Patch
Comment 4 EWS 2020-06-23 16:21:43 PDT 
Committed r263429: <https://trac.webkit.org/changeset/263429>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402601 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-23 16:22:14 PDT 
<rdar://problem/64669960>