Bug 213530 – [iOS] Open element actions sometimes result in a hover instead of a click

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Open element actions sometimes result in a hover instead of a click

[Andy Estes]

rdar://problem/64176707

[Andy Estes]

Created attachment 402595 [details]
Patch

[Darin Adler]

Comment on attachment 402595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402595&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:815
> +    auto delegate = _delegate.getAutoreleased();

Why autoreleased? Autoreleased has unwanted performance cost. We need it when the result is being used as a non-smart-pointer return value, and not in any other cases I can think of.

Let's use RetainPtr here, not autorelease. Just "auto delegate = _delegate.get()". This is analogous to what would be generated if we were using ARC, in fact.

At some point, most calls to getAutoreleased elsewhere should also be replaced with calls to get, with some minor refactoring possibly needed to work with RetainPtr rather than a raw pointer.

[Andy Estes]

(In reply to Darin Adler from comment #3)
> Comment on attachment 402595 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402595&action=review
> 
> > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:815
> > +    auto delegate = _delegate.getAutoreleased();
> 
> Let's use RetainPtr here, not autorelease.

Will do.

[Andy Estes]

Created attachment 402675 [details]
Patch

[EWS]

Committed r263472: <https://trac.webkit.org/changeset/263472>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402675 [details].