Bug 213528 - [WASM] [BigInt] Add I64 to BigInt conversion
Summary: [WASM] [BigInt] Add I64 to BigInt conversion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 220600 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-23 13:00 PDT by Keith Miller
Modified: 2021-01-20 01:57 PST (History)
11 users (show)

See Also:

Attachments
Patch (127.64 KB, patch)
2020-12-18 18:23 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (130.83 KB, patch)
2020-12-18 21:02 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (144.44 KB, patch)
2020-12-19 04:30 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (149.11 KB, patch)
2020-12-20 23:04 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (153.37 KB, patch)
2020-12-30 16:31 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (153.36 KB, patch)
2020-12-30 20:03 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-06-23 13:00:01 PDT 
Now that we have have a working BigInt implementation we should support the WASM <-> JS bindings for I64 to BigInt. See: https://github.com/WebAssembly/JS-BigInt-integration
Comment 1 Yusuke Suzuki 2020-12-18 18:23:52 PST 
Created attachment 416563 [details]
Patch
Comment 2 Yusuke Suzuki 2020-12-18 21:02:12 PST 
Created attachment 416566 [details]
Patch
Comment 3 Yusuke Suzuki 2020-12-19 04:30:03 PST 
Created attachment 416569 [details]
Patch
Comment 4 Yusuke Suzuki 2020-12-20 23:04:53 PST 
Created attachment 416595 [details]
Patch
Comment 5 Yusuke Suzuki 2020-12-30 16:31:32 PST 
Created attachment 416856 [details]
Patch

Rebaseline test expectation
Comment 6 Yusuke Suzuki 2020-12-30 20:03:24 PST 
Created attachment 416859 [details]
Patch
Comment 7 Michael Saboff 2021-01-05 10:59:22 PST 
Comment on attachment 416859 [details]
Patch

LGTM 
r=me
Comment 8 Yusuke Suzuki 2021-01-05 11:52:11 PST 
Comment on attachment 416859 [details]
Patch

Thanks! Landing.
Comment 9 EWS 2021-01-05 12:14:06 PST 
Committed r271168: <https://trac.webkit.org/changeset/271168>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416859 [details].
Comment 10 Radar WebKit Bug Importer 2021-01-05 12:15:30 PST 
<rdar://problem/72824086>
Comment 11 Yusuke Suzuki 2021-01-20 01:57:35 PST 
*** Bug 220600 has been marked as a duplicate of this bug. ***